Skip to content

London | 25-SDC-Nov | Jesus del Moral | Sprint 2 | Shell pipelines #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
delmorallopez wants to merge 4 commits into
base: main
Choose a base branch
from
Open

London | 25-SDC-Nov | Jesus del Moral | Sprint 2 | Shell pipelines #228

delmorallopez wants to merge 4 commits into from

Conversation

@delmorallopez
Copy link

@delmorallopez delmorallopez commented Nov 16, 2025 •
edited
Loading

Include the command ls, grep, tr, sort, uniq, head, tail

My changes meet the requirements of the task
I have tested my changes

Contains exercises to help you practice combining shell tools in pipelines.

Each folder is named after a group of tools, and contains exercises to practice using them.

@delmorallopez delmorallopez changed the title London | 25-SDC-Nov | Jesus del Moral | Sprint 1 | Shell pipelines London | 25-SDC-Nov | Jesus del Moral | Sprint 2 | Shell pipelines Nov 17, 2025
@delmorallopez delmorallopez added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module labels Nov 17, 2025
LonMcGregor
LonMcGregor reviewed Nov 25, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to make changes to all these files? We try to keep pull requests specific to just the files in the feature we are changing - for this, everything within the shell pipelines sprint task. I can't continue reviewing until the PR is made more specific.

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 25, 2025
@delmorallopez
Copy link
Author

delmorallopez commented Nov 26, 2025

Include the command ls, grep, tr, sort, uniq, head, tail

My changes meet the requirements of the task
I have tested my changes

Contains exercises to help you practice combining shell tools in pipelines.

Each folder is named after a group of tools, and contains exercises to practice using them.

@delmorallopez delmorallopez added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 26, 2025
LonMcGregor
LonMcGregor reviewed Dec 1, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just one issue in one of the tasks for you to take another look at

shell-pipelines/ls-grep/script-04.sh Outdated
# TODO: Write a command to count the number of files in the sample-files directory whose name starts with an upper case letter and doesn't contain any other upper case letters.
# Your output should be the number 7.

ls sample-files | grep '^[A-Z][^A-Z]*$' No newline at end of file
Copy link

@LonMcGregor LonMcGregor Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This task is asking to count the output, do you remember how to make grep do that?

Copy link
Author

@delmorallopez delmorallopez Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script has been modified and working properly

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. Complete Volunteer to add when work is complete and all review comments have been addressed. labels Dec 1, 2025
@LonMcGregor
Copy link

LonMcGregor commented Dec 1, 2025

Great!

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@delmorallopez @LonMcGregor