London | SDC-Nov-25 | Emiliano Uruena | Sprint 2 | Shell-Pipelines#234
Open
Emilianouz wants to merge 3 commits intoCodeYourFuture:mainfrom
Open
London | SDC-Nov-25 | Emiliano Uruena | Sprint 2 | Shell-Pipelines#234Emilianouz wants to merge 3 commits intoCodeYourFuture:mainfrom
Emilianouz wants to merge 3 commits intoCodeYourFuture:mainfrom
Conversation
Emilianouz
added
📅 Sprint 2
LonMcGregor
reviewed
Nov 25, 2025
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Did you mean to make changes to all these files? We try to keep pull requests specific to just the files in the feature we are changing - for this, everything within the shell pipelines sprint task. I can continue reviewing the PR once the number systems file is removed.
LonMcGregor
added
Reviewed
The file is not part of this Pull Request.
Author
|
Hi dear @LonMcGregor, |
Emilianouz
added
the
Needs Review
LonMcGregor
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Exercises Shell commands usging Pipeline and the commands: