Skip to content

Conversation

@Emilianouz
Copy link

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Exercises key jq logic to process JSON files: person and scores effectively.

  • Over person data, extracting and format names and locations.

  • Calculating each player's infor and score, using pipelines and add function.

@Emilianouz Emilianouz added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 3, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, I've left some comments where you could improve the PR further

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesn't need to be included in this PR for this sprint task, can you revert this please?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be possible to solve this with a single | add command, can you figure out how?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 23, 2025
This file doesn't belong to this module.
@Emilianouz Emilianouz added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 2 Assigned during Sprint 2 of this module and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 13, 2026
@github-actions
Copy link

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^jq/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
@github-actions
Copy link

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^jq/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment
@github-actions
Copy link

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^jq/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@Emilianouz Emilianouz added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
@github-actions
Copy link

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^jq/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
@Emilianouz Emilianouz added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
@github-actions
Copy link

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^jq/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
@Emilianouz Emilianouz changed the title London | SDC-Nov-25 | Emiliano Uruena | Sprint 2 | JSON-jq London | SDC-Nov-25 | Emiliano Uruena | Sprint 2 | JSON jq exercise Jan 13, 2026
@Emilianouz Emilianouz added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
@github-actions
Copy link

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^jq/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
@github-actions
Copy link

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^jq/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@LonMcGregor
Copy link

@Emilianouz To note why the bot is giving an error here, it looks like you have deleted the number systems file entirely. When you want to leave it unchanged in a pull request, you need to revert it back to the state it was in on the main branch. That way when you look at the changed files section in the PR here on github, it doesn't show up at all.

@Emilianouz
Copy link
Author

@Emilianouz To note why the bot is giving an error here, it looks like you have deleted the number systems file entirely. When you want to leave it unchanged in a pull request, you need to revert it back to the state it was in on the main branch. That way when you look at the changed files section in the PR here on github, it doesn't show up at all.

@LonMcGregor Thank you for your advice.
So, what can I do now?

@LonMcGregor
Copy link

@Emilianouz An easy way to revert any file to its original state is to use the following command git checkout ref path/to/the/file.txt . In this case, to revert the number systems file, you could use git checkout origin/main number-systems/README.md. Then make a commit as you normally would. if it works properly, you should be able to lookhere on the PR changed files section, and it will no longer be listed as changed or deleted.

@Emilianouz Emilianouz added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
@github-actions
Copy link

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^jq/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 13, 2026
@Emilianouz
Copy link
Author

@Emilianouz An easy way to revert any file to its original state is to use the following command git checkout ref path/to/the/file.txt . In this case, to revert the number systems file, you could use git checkout origin/main number-systems/README.md. Then make a commit as you normally would. if it works properly, you should be able to lookhere on the PR changed files section, and it will no longer be listed as changed or deleted.

I ran the command to restore the file. When I tried to pull, an error occurred, so I had to merge. However, it still isn’t validated.

@LonMcGregor
Copy link

You should not need to pull or merge anything. If you pull and merge from your branch, do you remember what that does? it takes the existing changes and adds them back in.
You are working in your own branch here - Sprint2-jq. From this branch, if you run the command, make a commit, then push, it should solve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants