Skip to content

Conversation

@Geraldine-Edwards
Copy link

…ments.txt

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

This PR contains the python implementation of a cowsay tool (inc requirements file)

Questions

Any refactoring advice welcome!

@Geraldine-Edwards Geraldine-Edwards changed the title Manchester | 25-SDC-Nov | Geraldine Edwards | Sprint 3 | Implement cowsay Manchester | 25-SDC-Nov | Geraldine Edwards | Sprint 4 | Implement cowsay Nov 28, 2025
@Geraldine-Edwards Geraldine-Edwards added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 28, 2025
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Dec 23, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution looks good. I don't see any big things that could be refactored.

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants