London | 25-SDC-Nov | Zohreh Kazemianpour | Sprint 5 | Laptop-allocation by zohrehKazemianpour · Pull Request #314 · CodeYourFuture/Module-Tools

zohrehKazemianpour · 2026-01-04T13:34:16Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

This PR implements laptop allocation.

…dness scores and improve overall allocation quality

OracPrime

Some intelligent coding here, nice!

Couple of questions to clear up, but overall good work.

OracPrime · 2026-01-11T15:17:23Z

laptop_allocation/laptop_allocation.py

+    name: str
+    age: int
+    # Sorted in order of preference, most preferred is first.
+    preferred_operating_system: tuple


Why a tuple rather than a list?

I used a tuple because Person needs to be hashable to serve as a dictionary key. If I used a list, Python would raise a TypeError: unhashable type: list

My version of python doesn't complain. What Python version are you using?

Ah, OK, I now understand it. The data being passed in is Tuples, so when I have preferred_operating_system as a list, Python ignores the type hint and stores the Tuple instead. I'm too used to strongly typed languages!

Take a gold star. Your Python knowledge exceeds mine in this respect (and probably many others, I'm guessing)

OracPrime · 2026-01-11T15:18:37Z

laptop_allocation/laptop_allocation.py

+         raise ValueError("Not enough laptops to allocate one per person")
+
+
+    people_sorted = sorted(people, key = lambda p: len(p.preferred_operating_system))


Nice touch - haven't seen anyone else do this, but it is a clever tweak to the algorithm

Thank you! I looked into more complex approaches like the Hungarian Algorithm, but found it a bit overwhelming at this stage for me. I decided to stick with greedy approach to ensure the pickest user get a compatible laptop before the more flexible users. With this we can minimise the overall sadness score for the group.

OracPrime · 2026-01-11T15:18:58Z

laptop_allocation/laptop_allocation.py

+    people_sorted = sorted(people, key = lambda p: len(p.preferred_operating_system))
+
+    result={}
+    available_laptops = laptops.copy()


Good spot that you need the copy if you don't want to change the original

OracPrime · 2026-01-11T15:19:44Z

laptop_allocation/laptop_allocation.py

+            sadness = calculate_sadness(person, laptop)
+            if sadness < smallest_sadness:
+                smallest_sadness = sadness 
+                best_laptop = laptop


You could of course break out of the loop if sadness is 0

That is a very good point, thanks for mentioning it. I've added a break when sadness == 0 to avoid unnecessary iterations.

OracPrime · 2026-01-11T15:20:16Z

laptop_allocation/laptop_allocation.py

+
+    return result
+
+allocate_laptops(people, laptops)


Why is this first call to allocate laptops here?

I removed the first call. it was a leftover from debugging. thanks for catching that.

zohrehKazemianpour · 2026-01-16T12:07:43Z

Some intelligent coding here, nice!

Couple of questions to clear up, but overall good work.

Thank you for the detailed review and the kind words! I really appreciate the feedback!

OracPrime

Thank you for educating me!

OracPrime · 2026-01-16T12:46:22Z

laptop_allocation/laptop_allocation.py

+    name: str
+    age: int
+    # Sorted in order of preference, most preferred is first.
+    preferred_operating_system: tuple


My version of python doesn't complain. What Python version are you using?

OracPrime · 2026-01-16T12:49:15Z

laptop_allocation/laptop_allocation.py

+    name: str
+    age: int
+    # Sorted in order of preference, most preferred is first.
+    preferred_operating_system: tuple


Ah, OK, I now understand it. The data being passed in is Tuples, so when I have preferred_operating_system as a list, Python ignores the type hint and stores the Tuple instead. I'm too used to strongly typed languages!

OracPrime · 2026-01-16T12:50:59Z

laptop_allocation/laptop_allocation.py

+    name: str
+    age: int
+    # Sorted in order of preference, most preferred is first.
+    preferred_operating_system: tuple


Take a gold star. Your Python knowledge exceeds mine in this respect (and probably many others, I'm guessing)

zohrehKazemianpour · 2026-01-16T13:36:44Z

Thank you for educating me!

Thank you so much for the prompt response! I truly appreciate the time and enery you put in to help us with our course work.

I have to confess, coming from JavaScript, it took me more than 3 weeks to finish these the two Python PRs. I will definitely plan to keep improve my Python. Your feedback made me so happy ; it is often hard to measure your own progress so it is great to know that hard work is paying off.

Please let me know if I need to make any other adjustment to finish this work or if it is ready for the complete label.

OracPrime · 2026-01-16T13:45:43Z

All done here!

zohrehKazemianpour · 2026-01-16T13:48:31Z

All done here!

I appreciate the complete label.

zohrehKazemianpour added 6 commits December 17, 2025 09:52

Update gitignore

7671cbc

Initialise the laptop allocation file

ffdcea1

Add find_preferred_laptops and calculate_sadness helper functions

333ea48

Allocate laptops using greedy algorithm

a0b9fcd

Validate laptop availability before allocation

76f824d

Optimise: Prioritise users with fewer OS preferences to avoid high sa…

3cedf09

…dness scores and improve overall allocation quality

zohrehKazemianpour added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 4, 2026

OracPrime added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jan 11, 2026

OracPrime reviewed Jan 11, 2026

View reviewed changes

refactor: remove redundant call and optimise allocation loop

633a08e

zohrehKazemianpour added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 16, 2026

OracPrime approved these changes Jan 16, 2026

View reviewed changes

OracPrime added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 16, 2026

		raise ValueError("Not enough laptops to allocate one per person")


		people_sorted = sorted(people, key = lambda p: len(p.preferred_operating_system))

Uh oh!

Conversation

zohrehKazemianpour commented Jan 4, 2026

Learners, PR Template

Changelist

Uh oh!

OracPrime left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zohrehKazemianpour commented Jan 16, 2026

Uh oh!

OracPrime left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zohrehKazemianpour commented Jan 16, 2026

Uh oh!

OracPrime commented Jan 16, 2026

Uh oh!

zohrehKazemianpour commented Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants