Skip to content

London | 25-SDC-July | Andrei Filippov | Sprint 1 | Number systems exercises #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Droid-An wants to merge 6 commits into
base: main
Choose a base branch
from
Open

London | 25-SDC-July | Andrei Filippov | Sprint 1 | Number systems exercises #69

Droid-An wants to merge 6 commits into from

Conversation

@Droid-An
Copy link

@Droid-An Droid-An commented Jul 11, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

done exercises

Questions

no questions

@Droid-An Droid-An changed the title LONDON-JAN-25 | ANDREI FILIPPOV | MODULE TOOLS | WEEEK1 LONDON-JAN-25 | ANDREI FILIPPOV | MODULE TOOLS | WEEEK 1 Jul 11, 2025
@Droid-An Droid-An added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 14, 2025
@Droid-An Droid-An changed the title LONDON-JAN-25 | ANDREI FILIPPOV | MODULE TOOLS | WEEEK 1 London | 25-SDC-July | Andrei Filippov | Sprint 1 | Number systems exercises Jul 14, 2025
@chinar-amrutkar chinar-amrutkar self-assigned this Jul 16, 2025
@Droid-An Droid-An added the 📅 Sprint 1 Assigned during Sprint 1 of this module label Jul 18, 2025
@chinar-amrutkar chinar-amrutkar self-requested a review July 22, 2025 08:39
chinar-amrutkar
chinar-amrutkar reviewed Jul 22, 2025
View reviewed changes
Copy link

@chinar-amrutkar chinar-amrutkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! There are a few errors which you need to correct, hopefully the hints help!

number-systems/README.md Outdated

How many bits would you need in order to store the numbers between 0 and 255 inclusive?
Answer:
Answer: 7
Copy link

@chinar-amrutkar chinar-amrutkar Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think about what 255 looks like in binary form. How many bits does it have?

Copy link
Author

@Droid-An Droid-An Jul 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be 11111111, so I’ll need 8 bits for this. I completely forgot that the last digit in a binary number represents 2 to the power of 0, not 1.

number-systems/README.md Outdated

How many bits would you need in order to store the numbers between 0 and 1000 inclusive?
Answer:
Answer: 9
Copy link

@chinar-amrutkar chinar-amrutkar Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think about what 1000 looks like in binary form. How many bits does it have?

Copy link
Author

@Droid-An Droid-An Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1111101000 has 10 bits, so I need 10 bits. I made the same mistake again - I forgot that the rightmost digit represents 2 to the power of 0.

number-systems/README.md Outdated

Convert the decimal number 14 to hex.
Answer:
Answer: F
Copy link

@chinar-amrutkar chinar-amrutkar Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think again!
Hint - you start counting the alphabets from 10, not 11

number-systems/README.md

If reading the byte 0x21 as a greyscale colour, as described in "Approaches for Representing Colors and Images", what colour would it mean?
Answer:
Answer: Gray colour with light intensity equals 33
Copy link

@chinar-amrutkar chinar-amrutkar Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the gray light?

Copy link
Author

@Droid-An Droid-An Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand the question clearly. Are you asking why the colour is grey, or why it's light instead of dark

@chinar-amrutkar chinar-amrutkar added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 22, 2025
@Droid-An Droid-An added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 31, 2025
@LonMcGregor
Copy link

LonMcGregor commented Aug 20, 2025

Hi Andrei, I think the only question left here is when the reviewer was asking about the grey colour. When you say "light intensity equals 33" - what would this look like if displayed on a screen? Can you describe that colour in general terms

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 20, 2025
@Droid-An
Copy link
Author

Droid-An commented Aug 20, 2025

Hi. Since grayscale images are commonly represented with 8 bits per pixel, allowing for 256 shades of grey, where 0 corresponds to black (no light intensity) and 255 to white (full intensity), I would describe the colour 0x21 as a dark grey.

@Droid-An Droid-An added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Aug 20, 2025
@LonMcGregor
Copy link

LonMcGregor commented Aug 25, 2025

Great - you are done with this sprint now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chinar-amrutkar chinar-amrutkar chinar-amrutkar left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@chinar-amrutkar chinar-amrutkar

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Droid-An @LonMcGregor @chinar-amrutkar