You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Removes the Freebuff waiting-room feature flag now that the session gate is permanently enabled. The server always starts admission, no longer emits disabled gate responses, and no longer fetches user email for the removed bypass path. CLI compatibility for older servers is preserved with the client-side disabled fallback, while docs and tests now describe the always-on session gate. Validated with package typechecks, focused Freebuff/session tests, chat completions tests, admission tests, and git diff --check.
This PR removes the FREEBUFF_WAITING_ROOM_ENABLED flag now that the session gate is always on, and the change itself looks clean and well-tested — the CLI-side compatibility fallback for older servers, the doc updates in docs/freebuff-waiting-room.md, and the removal of the team@codebuff.com bypass and unused userEmail plumbing all read as a coherent, deliberate cleanup with corresponding test removals rather than blind churn.
However, per this mirror's scope rules, changes to web/ and packages/internal/ are not accepted here regardless of quality. The bulk of the substantive logic changes are in web/src/server/free-session/*, web/src/app/api/v1/freebuff/session/*, web/src/app/api/v1/chat/completions/*, and packages/internal/src/env-schema.ts — all out-of-scope paths for this repo. Only the CLI-side comment tweaks and doc changes would be in-scope, and those are cosmetic without the server-side change they describe.
If you want this ported, it needs to go through the private repo directly since the core of the diff can't land here. Nothing wrong with the work, just the wrong venue for the parts that matter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bot:triagedClassified by the community triage botpr:out-of-scopeTouches paths the public mirror does not accept
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the Freebuff waiting-room feature flag now that the session gate is permanently enabled. The server always starts admission, no longer emits disabled gate responses, and no longer fetches user email for the removed bypass path. CLI compatibility for older servers is preserved with the client-side disabled fallback, while docs and tests now describe the always-on session gate. Validated with package typechecks, focused Freebuff/session tests, chat completions tests, admission tests, and git diff --check.