Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Term Entry] PyTorch Tensors .full() #5341

Closed
wants to merge 9 commits into from
Closed

Conversation

SaviDahegaonkar
Copy link
Collaborator

Description

Created a new term entry for PyTorch tensors .full( ) function.

Issue Solved

#5304

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@SaviDahegaonkar SaviDahegaonkar added new entry New entry or entries pytorch PyTorch labels Sep 27, 2024
@mamtawardhani mamtawardhani self-assigned this Sep 27, 2024
@mamtawardhani mamtawardhani added the status: under review Issue or PR is currently being reviewed label Sep 27, 2024
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SaviDahegaonkar thank you for contributing to Docs. 😄

I've suggested changes for your entry, kindly review and modify them at your earliest, I would also request you to review some points mentioned here that would help you in your feedbacks as well 😃
Thank you!

@@ -0,0 +1,59 @@
---
Title: '.full()'
Description: 'In PyTorch, the `.full()` function creates a tensor filled with a specified value and shape according according to the dimensions provided.'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thr description should always start with a verb, in this case it can start with "Creates a tensor..".

content/pytorch/concepts/tensors/terms/full/full.md Outdated Show resolved Hide resolved
content/pytorch/concepts/tensors/terms/full/full.md Outdated Show resolved Hide resolved
content/pytorch/concepts/tensors/terms/full/full.md Outdated Show resolved Hide resolved
content/pytorch/concepts/tensors/terms/full/full.md Outdated Show resolved Hide resolved
content/pytorch/concepts/tensors/terms/full/full.md Outdated Show resolved Hide resolved
Comment on lines 45 to 59
## Codebyte Example

```codebyte/python
import torch

# Create a 2x3 tensor filled with the value 10
tensor = torch.full((2, 3), 10)

print(tensor)
```





Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this, as we don't require a running codebyte for Pytorch, since compiler doesn't support pytorch. Also remove the extra lines at the end

@mamtawardhani
Copy link
Collaborator

@SaviDahegaonkar can you make the required changes on priority?

@SaviDahegaonkar
Copy link
Collaborator Author

Hello @mamtawardhani , I have made the changes, Please check them and let me know if any further changes are required.

Thanks,
Savi

@mamtawardhani mamtawardhani added invalid This doesn't seem right; not eligible for Hacktoberfest and removed status: review 1️⃣ completed status: waiting for author labels Oct 15, 2024
@mamtawardhani
Copy link
Collaborator

Hey @SaviDahegaonkar closing this PR as it is not from the forked repository and directly from the main docs. Please raise another PR for this. Thank you 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right; not eligible for Hacktoberfest new entry New entry or entries pytorch PyTorch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants