Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created activation functions in Pytorch #5458

Merged
merged 49 commits into from
Nov 16, 2024

Conversation

arisdelacruz
Copy link
Contributor

Description

This is an attempt to create an entry for the Activation functions in Pytorch.

Issue Solved

Closes #5231

Type of Change

  • Adding a new entry

Checklist

  • [/] All writings are my own.
  • [/] My entry follows the Codecademy Docs style guide.
  • [/] My changes generate no new warnings.
  • [/] I have performed a self-review of my own writing and code.
  • [/] I have checked my entry and corrected any misspellings.
  • [/] I have made corresponding changes to the documentation if needed.
  • [/] I have confirmed my changes are not being pushed from my forked main branch.
  • [/] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [/] I have linked any issues that are relevant to this PR in the Issues Solved section.

@mamtawardhani mamtawardhani self-assigned this Oct 13, 2024
@mamtawardhani mamtawardhani added new entry New entry or entries status: under review Issue or PR is currently being reviewed pytorch PyTorch labels Oct 13, 2024
@mamtawardhani
Copy link
Collaborator

Hey @arisdelacruz the path of the file seems to be incorrect. It should be content/pytorch/concepts/nn/activation-functions/activation-functions.md, but your entry is missing the terms folder. Please make that change

Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @arisdelacruz thank you for contributing to Codecademy Docs, the entry is nicely written! 😄

I've suggested a few modifications, could review and make the changes at your earliest convenience? Also, the path of the file seems to be incorrect, the terms folder is missing, please correct that as well.
Thank you! 😄

arisdelacruz and others added 12 commits October 15, 2024 21:30
@Radhika-okhade Radhika-okhade added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Nov 15, 2024
Copy link
Collaborator

@Radhika-okhade Radhika-okhade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Codecademy docs. The entry looks good to be merged.

@Radhika-okhade Radhika-okhade merged commit 9c4bb54 into Codecademy:main Nov 16, 2024
6 checks passed
Copy link

👋 @arisdelacruz
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/pytorch/nn/activation-functions

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Term Entry] PyTorch nn Activation Functions
5 participants