Skip to content

Conversation

@katiezutter
Copy link
Contributor

@katiezutter katiezutter commented Oct 22, 2025

Overview

Adds ArrowUpHeavy icon.

PR Checklist

Testing Instructions

  1. Visit https://tayra.codecademy.com/learner-builder/new?PR_ENV=le-pr-11556 as an Optimizely test user
  2. Check the icon on the submit button

PR Links and Envs

Repository PR Link
Mono Mono PR

@nx-cloud
Copy link

nx-cloud bot commented Oct 22, 2025

View your CI Pipeline Execution ↗ for commit 21365cc

Command Status Duration Result
nx run-many --target=verify --parallel=3 --all ✅ Succeeded <1s View ↗
nx run-many --target=build --all ✅ Succeeded 31s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-22 18:26:42 UTC

@codecademydev
Copy link
Collaborator

📬 Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]
@codecademy/[email protected]

@github-actions
Copy link
Contributor

@katiezutter katiezutter marked this pull request as ready for review October 22, 2025 21:04
@katiezutter katiezutter requested a review from a team as a code owner October 22, 2025 21:04
@speterson-cc
Copy link

In order to add to the regular set, the icon has to be 1.5px and come from the "Ultimate regular" set from Streamline. This looks like it came from a different, heavier set and doesn't have a stroke. This is so that it works with the rest of our icon set consistently.

@katiezutter
Copy link
Contributor Author

In order to add to the regular set, the icon has to be 1.5px and come from the "Ultimate regular" set from Streamline. This looks like it came from a different, heavier set and doesn't have a stroke. This is so that it works with the rest of our icon set consistently.

@speterson-cc gotcha, makes sense. Is there a better place to add this, or should it not be added to Gamut at all? Working with this design: https://www.figma.com/design/YEkxyL9gxflceQJ2KQDXgT/%F0%9F%90%AD-2.0-concepts?node-id=1428-23667&t=2DwP9rAx6BmhpzD6-4

@dreamwasp
Copy link
Contributor

In order to add to the regular set, the icon has to be 1.5px and come from the "Ultimate regular" set from Streamline. This looks like it came from a different, heavier set and doesn't have a stroke. This is so that it works with the rest of our icon set consistently.

@speterson-cc gotcha, makes sense. Is there a better place to add this, or should it not be added to Gamut at all? Working with this design: https://www.figma.com/design/YEkxyL9gxflceQJ2KQDXgT/%F0%9F%90%AD-2.0-concepts?node-id=1428-23667&t=2DwP9rAx6BmhpzD6-4

is there a reason not to just use an up arrow that already exists in Gamut? you're free to add it locally to your project it just seems strange to me that we would need more than a few variants (and is visually confusing, imo). i also know this is coming from design so you're just the messenger here 😅

@katiezutter
Copy link
Contributor Author

In order to add to the regular set, the icon has to be 1.5px and come from the "Ultimate regular" set from Streamline. This looks like it came from a different, heavier set and doesn't have a stroke. This is so that it works with the rest of our icon set consistently.

@speterson-cc gotcha, makes sense. Is there a better place to add this, or should it not be added to Gamut at all? Working with this design: https://www.figma.com/design/YEkxyL9gxflceQJ2KQDXgT/%F0%9F%90%AD-2.0-concepts?node-id=1428-23667&t=2DwP9rAx6BmhpzD6-4

is there a reason not to just use an up arrow that already exists in Gamut? you're free to add it locally to your project it just seems strange to me that we would need more than a few variants (and is visually confusing, imo). i also know this is coming from design so you're just the messenger here 😅

@dreamwasp I'll ask Kat about this!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants