-
Notifications
You must be signed in to change notification settings - Fork 32
feat: Add ArrowUpHeavy icon #3195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
View your CI Pipeline Execution ↗ for commit 21365cc
☁️ Nx Cloud last updated this comment at |
|
📬 Published Alpha Packages: |
|
🚀 Styleguide deploy preview ready! Preview URL: https://68f9229a97dced3a076ca843--gamut-preview.netlify.app |
|
In order to add to the regular set, the icon has to be 1.5px and come from the "Ultimate regular" set from Streamline. This looks like it came from a different, heavier set and doesn't have a stroke. This is so that it works with the rest of our icon set consistently. |
@speterson-cc gotcha, makes sense. Is there a better place to add this, or should it not be added to Gamut at all? Working with this design: https://www.figma.com/design/YEkxyL9gxflceQJ2KQDXgT/%F0%9F%90%AD-2.0-concepts?node-id=1428-23667&t=2DwP9rAx6BmhpzD6-4 |
is there a reason not to just use an up arrow that already exists in Gamut? you're free to add it locally to your project it just seems strange to me that we would need more than a few variants (and is visually confusing, imo). i also know this is coming from design so you're just the messenger here 😅 |
@dreamwasp I'll ask Kat about this!! |
Overview
Adds ArrowUpHeavy icon.
PR Checklist
Testing Instructions
PR Links and Envs