-
Notifications
You must be signed in to change notification settings - Fork 31
docs: Add Gamut writing guide #3197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
View your CI Pipeline Execution ↗ for commit dbb5e09 ☁️ Nx Cloud last updated this comment at |
aresnik11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial thoughts!
packages/styleguide/src/lib/Meta/Style Guide/Component Pages.mdx
Outdated
Show resolved
Hide resolved
packages/styleguide/src/lib/Meta/Style Guide/Component Pages.mdx
Outdated
Show resolved
Hide resolved
packages/styleguide/src/lib/Meta/Style Guide/Component Pages.mdx
Outdated
Show resolved
Hide resolved
packages/styleguide/src/lib/Meta/Style Guide/Computer Interfaces.mdx
Outdated
Show resolved
Hide resolved
packages/styleguide/src/lib/Meta/Style Guide/Computer Interfaces.mdx
Outdated
Show resolved
Hide resolved
packages/styleguide/src/lib/Meta/Style Guide/Computer Interfaces.mdx
Outdated
Show resolved
Hide resolved
packages/styleguide/src/lib/Meta/Style Guide/Component Pages.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Amy Resnik <[email protected]>
Co-authored-by: Amy Resnik <[email protected]>
…es.mdx Co-authored-by: Amy Resnik <[email protected]>
dreamwasp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, def want emily to take a look!
packages/styleguide/src/lib/Meta/Style Guide/Component Pages.mdx
Outdated
Show resolved
Hide resolved
packages/styleguide/src/lib/Meta/Style Guide/Computer Interfaces.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally had a chance to get my thoughts down, and there are a lot of them but I'm generally very excited about this. Great job on it!
Two other, more meta questions:
- Should this guide live in Storybook? If it's for people writing Gamut documentation, my inclination is that it should be part of a contribution guide rather than part of Gamut docs.
- How do we want to this guide to relate to Codecademy styling and grammar? Should our guide be aware of it? In deference to it? The draft you've written doesn't currently seem to acknowledge it and even conflicts with it in a few places (I only noted one).
| ## Voice and Tone | ||
|
|
||
| - Friendly and conversational: Write as if explaining to a colleague | ||
| - Direct and action-oriented: Use "you" to address readers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I much prefer "we" in any writing where the reader is learning from an expert because it quietly invites the reader to be the expert, whereas "you" creates a line between author and reader: "I the expert am telling you the novice what's what." Or more simply, "we" is inclusive, "you" creates separation.
My general advice here is to prefer "we" whenever possible because there will be times when "you" is the better choice. For instance, it wouldn't make sense to say "use our best judgment" if we're encouraging the reader to use their judgment, so "use your best judgment" would be fine. But those instances are surprisingly rare—we can usually use "we" for most things without much effort.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For product copy/UX writing we :) generally use "we" as the voice of the company, and we use "you" for a more conversational tone with learners.
I can understand this sentiment of being inclusive for this context of documentation. One question: I remember seeing a reference to being explicit about "we" as Codecademy where applicable (can't seem to find it right now)... would we want to place that piece of information closer to this, since Gamut is public and referred to from some of our courses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our users are primarily (entirely?) other Skillsoft employees, which is one reason we might want this to be different from company style.
As an aside, this was a very specific style point that was used to great effect at Norton. When we switched to using "we" in our composition list in particular, we saw huge growth (it was accompanied by lots of other changes, but this one was notable to our editor). Instead of an expert telling you—the learner—how to write, we were writing together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we can take this in different directions —
- where we explicitly call out when to use "we" (maybe add this in as part of line 18)
- removing/rewriting line 19 to emphasize "we" more
I think it seems to lean more towards point 1, where we call out the usage of "we" (there is also a separate section in "Language and Grammar" that touches upon this.
Will note that we should discuss as a group
packages/styleguide/src/lib/Meta/Gamut writing guide/General principles.mdx
Outdated
Show resolved
Hide resolved
packages/styleguide/src/lib/Meta/Gamut writing guide/General principles.mdx
Show resolved
Hide resolved
|
|
||
| - Use bash syntax highlighting | ||
| - Don't include command prompt symbols ($, #) | ||
| - Use yarn as the default package manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not include user space technology choices in our guidelines. If anything, we should recommend documentation writers be inclusive about the technology choices of our users.
# install with your package manager of choice
npm install @codecademy/gamut-kit
pnpm add @codecademy/gamut-kit
yarn add @codecademy/gamut-kitOr better yet, let the user choose their package manager globally and then just show commands for it.
For instance, this is what I did for the Norton Design System's getting started guide (source code).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems more inline with the Installation guide we have up, but I can't seem to find the ticket rn, will revisit
packages/styleguide/src/lib/Meta/Style Guide/Referencing Code.mdx
Outdated
Show resolved
Hide resolved
packages/styleguide/src/lib/Meta/Style Guide/Referencing Code.mdx
Outdated
Show resolved
Hide resolved
packages/styleguide/src/lib/Meta/Style Guide/Referencing Code.mdx
Outdated
Show resolved
Hide resolved
packages/styleguide/src/lib/Meta/Gamut Writing Guide/Stories.mdx
Outdated
Show resolved
Hide resolved
|
Another thought: a lot of this guidance would be very useful in an agent instructions/rules/skills file. I often have Cursor help me write docs, and it always seems to format things in ways I don't like, so I end up having to correct it. This guide would be a huge help with that. For instance:
|
packages/styleguide/src/lib/Meta/Gamut writing guide/Language and grammar.mdx
Show resolved
Hide resolved
packages/styleguide/src/lib/Meta/Style Guide/General Principles.mdx
Outdated
Show resolved
Hide resolved
packages/styleguide/src/lib/Meta/Gamut writing guide/Language and grammar.mdx
Outdated
Show resolved
Hide resolved
packages/styleguide/src/lib/Meta/Style Guide/Language and Grammer.mdx
Outdated
Show resolved
Hide resolved
packages/styleguide/src/lib/Meta/Gamut writing guide/Language and grammar.mdx
Show resolved
Hide resolved
packages/styleguide/src/lib/Meta/Style Guide/Referencing Code.mdx
Outdated
Show resolved
Hide resolved
dreamwasp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have the tiniest comments but this looks great to me
| ### Components | ||
|
|
||
| - Use `PascalCase` for component names: `Button`, `UserProfile`, `NavigationMenu` | ||
| - Name files to match the component: `Button.tsx`, `UserProfile.tsx` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we usually will do a folder name in addition to a file name for components
|
📬 Published Alpha Packages: |
|
🚀 Styleguide deploy preview ready! Preview URL: https://6938717c28c0af1a5315f7d7--gamut-preview.netlify.app |
Overview
Adds a style guide for documentation purposes
PR Checklist
Testing Instructions
Don't make me tap the sign.
/?path=/docs/meta-style-guide-about--docsPR Links and Envs
N/A