Skip to content

Conversation

@LinKCoding
Copy link
Contributor

@LinKCoding LinKCoding commented Dec 4, 2025

Overview

Fixes Card boxShadow styling for the isInteractive outline variant by adding an initial animation and separate animations for outlineInitial and outlineAnimate

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-136
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Here's how the non-animated, but isInteractive states look:
image

Here's how the animated states look:
image

  1. Go to Card component story in Storybook
  2. Check over the isInteractive story
  3. Hover over the card to confirm the shadow animation is consistent for all Card instances
  4. Check over the outline variant specifically and notice that there's no longer a jump from outline to boxshadow
  5. Test in both light and dark mode

PR Links and Envs

Repository PR Link
Monolith Monolith PR
Mono Mono PR

@nx-cloud
Copy link

nx-cloud bot commented Dec 4, 2025

View your CI Pipeline Execution ↗ for commit fa2341e


☁️ Nx Cloud last updated this comment at 2025-12-12 16:14:32 UTC

@LinKCoding LinKCoding changed the title fix(Card): correct isInteractive prop's boxshadow dimensions fix(Card): correct isInteractive prop's related boxshadow animation Dec 12, 2025
@LinKCoding LinKCoding marked this pull request as ready for review December 12, 2025 16:12
@LinKCoding LinKCoding requested a review from a team as a code owner December 12, 2025 16:12
@codecademydev
Copy link
Collaborator

📬 Published Alpha Packages:

@codecademy/[email protected]
@codecademy/[email protected]

@github-actions
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants