Skip to content

Conversation

@LinKCoding
Copy link
Contributor

@LinKCoding LinKCoding commented Dec 5, 2025

Overview

Updates instructions for adding icons to accurately reflect naming convention

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: GMT-1525
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

  1. Go to Icons about page: /?path=/docs/atoms-icons-about--docs
  2. Read over the instructions, notice that the naming for .svg files is updated
  3. Verify that this naming convention fits with how gamut SVGs are stored
  4. ...
  5. Finish and do a celebratory dance

PR Links and Envs

N/A

@nx-cloud
Copy link

nx-cloud bot commented Dec 5, 2025

View your CI Pipeline Execution ↗ for commit 5522ce2


☁️ Nx Cloud last updated this comment at 2025-12-12 02:25:25 UTC

@LinKCoding LinKCoding marked this pull request as ready for review December 5, 2025 21:55
@LinKCoding LinKCoding requested a review from a team as a code owner December 5, 2025 21:55
@codecademydev
Copy link
Collaborator

📬 Published Alpha Packages:

@codecademy/[email protected]

@github-actions
Copy link
Contributor

@LinKCoding LinKCoding added the Ship It :shipit: Automerge this PR when possible label Dec 12, 2025
@codecademydev codecademydev merged commit 6de9111 into main Dec 12, 2025
17 of 18 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Dec 12, 2025
@codecademydev codecademydev deleted the kl-gmt-1525-icons-naming branch December 12, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants