-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds Unkey for API key generation #27
base: main
Are you sure you want to change the base?
Conversation
@domeccleston is attempting to deploy a commit to the meglerhagen's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments for generate-api-key.ts ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Codehagen, I've resolved the type errors here by changing the error handling in the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure why those weren't showing for me previously
const { | ||
result: { key: apiKey }, | ||
} = await unkey.keys.create({ | ||
const { result } = await unkey.keys.create({ | ||
apiId: "api_3PkKmeLT2WeGsbRUVWH1YAZJK886", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the problem is that this is @domeccleston's hardcoded apiID, @Codehagen needs to use their own from the unkey dashboard.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merging this within the weekend 👍 @chronark |
Just merged main into this to resolve some merge conflicts. Still getting an error. Have not read the documentation, but was wondering if you guys know? @chronark @domeccleston Took the API from the project into this |
Description
1-minute overview Loom
This replaces custom API key generation logic with the Unkey SDK. It adds a custom prefix for keys and fast rate limiting. Also updates the docs.
What type of PR is this? (check all applicable)
Related Tickets & Documents
None
Mobile & Desktop Screenshots/Recordings
Steps to QA
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
No
[optional] What gif best describes this PR or how it makes you feel?