FESI1-106: QA fix complete #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0juicy
reviewed
Feb 12, 2025
| <div className="flex gap-2"> | ||
| <div className="flex w-full justify-center gap-6 min-[1111px]:justify-start"> | ||
| <section | ||
| className="w-full max-w-[326px] |
Collaborator
There was a problem hiding this comment.
피그마 시안에 있는 요소의 크기 값이 326px지만,
디자이너님은 양 옆 마진 값을 남기고 내부 요소가 꽉 차도록 의도하신 것 같습니다.
요소의 크기 값을 직접 지정해주기보다 w-full과 마진을 활용하는 게 반응형 디자인을 구현하기 편할 것 같아요.
0juicy
reviewed
Feb 12, 2025
Comment on lines
138
to
+154
| <GatheringBadge | ||
| shape="round" | ||
| icon={level as keyof typeof levelIcons} | ||
| className="text-xs md:text-sm lg:text-base" | ||
| > | ||
| {levelLabels[level as keyof typeof levelLabels]} | ||
| </GatheringBadge> | ||
| <GatheringBadge shape="round">{locationLabel}</GatheringBadge> | ||
| <GatheringBadge shape="round"> | ||
| <GatheringBadge | ||
| shape="round" | ||
| className="text-xs md:text-sm lg:text-base" | ||
| > | ||
| {locationLabel} | ||
| </GatheringBadge> | ||
| <GatheringBadge | ||
| shape="round" | ||
| className="text-xs md:text-sm lg:text-base" | ||
| > |
Collaborator
There was a problem hiding this comment.
스타일이 다른 부분이 있습니다.
테두리, 색상 변경 부탁드려요.
LevelBadge 컴포넌트가 있는데 활용해도 좋을 것 같습니다.
0juicy
reviewed
Feb 12, 2025
Comment on lines
+196
to
216
| {/* 제목 */} | ||
| <h1 | ||
| className="font-noto mt-6 text-xl | ||
| leading-6 text-white | ||
| md:text-2xl md:leading-7 | ||
| lg:text-[26px] lg:leading-[28px]" | ||
| > | ||
| {name} | ||
| </h1> | ||
|
|
||
| {/* 위치 정보 */} | ||
| <div className="mt-6 space-y-6"> | ||
| <div className="flex items-center gap-2"> | ||
| <Image | ||
| src="/icons/location.svg" | ||
| width={24} | ||
| height={24} | ||
| alt="위치 아이콘" | ||
| /> | ||
| <span className="text-white">{locationLabel}</span> | ||
| </div> |
Collaborator
There was a problem hiding this comment.
디자인 상에서 두 요소가 묶여있는 경우 mt를 각 요소에 적용하기 보다,
flex flex-col gap-2를 활용해서 간격을 조절하는 것이 직관적이고 편리할 것 같습니다.
0juicy
reviewed
Feb 12, 2025
Comment on lines
48
to
+50
| {/* 방탈출 정보 섹션 */} | ||
| <div> | ||
| <h2 className="font-noto mb-4 text-[26px] leading-[28px]"> | ||
| <h2 |
Collaborator
There was a problem hiding this comment.
위에 리뷰 코멘트를 남겼던 것과 같이, className이 없는 wrapper div태그에 flex 값을 주어
요소 사이 간격을 자동으로 조절하는 방식도 편리할 것 같습니다.
Collaborator
|
😃 살짝만 다듬으면 이제 완성인 것 같네요! 고생하셨습니다. 디자인 시안이 다른 부분에 대해 코멘트 남긴 것 외의 리뷰는 저의 개인적인 의견이니 참고만 해주시고 꼭 반영하지 않으셔도 됩니다! |
0juicy
approved these changes
Feb 12, 2025
wkdwlgo
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ 작업 내용 요약
🏷️ 연관된 JIRA 번호