Feat/98/crew api 연결 : 바뀐 백엔드 API 다시 적용 #119
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,8 +31,8 @@ function CrewCardList( | |
| ) { | ||
| const crewDataList = | ||
| (inWhere === 'my-crew' | ||
| ? data?.pages.flatMap((page) => page?.content) | ||
| : data?.pages?.flatMap((page) => page?.content)) ?? []; | ||
| const gridColsStyle = inWhere === 'my-crew' ? '' : 'lg:grid-cols-2'; | ||
|
|
||
| if (data?.pages[0] === undefined) | ||
|
|
@@ -63,7 +63,11 @@ function CrewCardList( | |
| title={inform?.title} | ||
| mainLocation={inform?.mainLocation} | ||
| subLocation={inform?.subLocation} | ||
| imageUrl={ | ||
| inform?.imageUrl === 'string' | ||
| ? 'https://media.istockphoto.com/id/1396814518/vector/image-coming-soon-no-photo-no-thumbnail-image-available-vector-illustration.jpg?s=612x612&w=0&k=20&c=hnh2OZgQGhf0b46-J2z7aHbIWwq8HNlSDaNp2wn_iko=' | ||
| : inform?.imageUrl | ||
| } | ||
| totalCount={inform?.totalCount} | ||
| participantCount={ | ||
| inWhere === 'my-crew' | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -65,6 +65,6 @@ export interface MyCrewList { | |
| } | ||
|
|
||
| export interface MyCrewListResponse { | ||
| content: MyCrewList[]; | ||
| hasNext: boolean; | ||
| } | ||
|
Comment on lines
+68
to
70
There was a problem hiding this comment. 💡 Codebase verification 일부 관련 컴포넌트들이 아직 'data' 속성을 사용하고 있습니다.
🔗 Analysis chain관련 컴포넌트들의 업데이트 여부를 확인해주세요. 이 인터페이스를 사용하는 모든 컴포넌트들이 새로운 속성 이름( 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: 이 인터페이스를 사용하는 컴포넌트들을 검색하여 업데이트가 필요한 부분을 확인합니다.
# MyCrewListResponse 타입을 사용하는 파일들을 검색
echo "MyCrewListResponse를 사용하는 파일 검색:"
rg "MyCrewListResponse" --type ts --type tsx
# 이전 속성명 'data'를 여전히 사용하고 있는 코드를 검색
echo "\n이전 속성명 'data'를 사용하는 코드 검색:"
rg "data\?\.pages" --type ts --type tsx
Length of output: 288 Script: #!/bin/bash
# Description: 이 인터페이스를 사용하는 컴포넌트들을 다시 검색하여 업데이트가 필요한 부분을 확인합니다.
# MyCrewListResponse 타입을 사용하는 파일들을 검색 (.ts, .tsx 파일)
echo "MyCrewListResponse를 사용하는 파일 검색 (ts, tsx):"
rg "MyCrewListResponse" -g "*.ts" -g "*.tsx"
# 이전 속성명 'data'를 여전히 사용하는 코드를 검색 (.ts, .tsx 파일)
echo "\n이전 속성명 'data'를 사용하는 코드 검색 (ts, tsx):"
rg "data\?\.pages" -g "*.ts" -g "*.tsx"
Length of output: 1202 |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API 호출에서 오류 처리가 누락되었습니다.
API 호출 시 발생할 수 있는 네트워크 오류나 서버 오류에 대한 처리가 없습니다. 사용자 경험 향상을 위해 적절한 오류 처리가 필요합니다.
다음과 같이 오류 처리를 추가하는 것을 제안드립니다:
async function getCrewList(condition: ConditionTypes, pageable: PageableTypes) { const { keyword, mainLocation, mainCategory, subCategory, sortType } = condition; const { page, size, sort = ['string'] } = pageable; + try { const response: { data: MainCrewListResponse } = await fetchApi( `/api/crews/search?keyword=${keyword}&mainLocation=${mainLocation}&mainCategory=${mainCategory}&subCategory=${subCategory}&sortType=${sortType}&page=${page}&size=${size}&sort=${sort}`, { method: 'GET', headers: { 'Content-Type': 'application/json', }, credentials: 'include', }, ); return response?.data; + } catch (error) { + console.error('크루 목록을 불러오는 중 오류가 발생했습니다:', error); + throw new Error('크루 목록을 불러오는데 실패했습니다.'); + } }📝 Committable suggestion