Feat/128/edit crew api 연결 #129
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -1,9 +1,53 @@ | ||||||||
| import { toast } from 'react-toastify'; | ||||||||
| import { useRouter } from 'next/navigation'; | ||||||||
| import { useMutation, useQuery, useQueryClient } from '@tanstack/react-query'; | ||||||||
| import { createCrew, editCrew } from '@/src/_apis/crew/crew'; | ||||||||
| import { getCrewDetail } from '@/src/_apis/crew/crew-detail-apis'; | ||||||||
| import { CreateCrewRequestTypes, EditCrewRequestTypes } from '@/src/types/create-crew'; | ||||||||
|
|
||||||||
| export function useGetCrewDetailQuery(id: number) { | ||||||||
| return useQuery({ | ||||||||
| queryKey: ['crewDetail', id], | ||||||||
| queryFn: () => getCrewDetail(id), | ||||||||
| }); | ||||||||
| } | ||||||||
|
|
||||||||
| export function useCreateCrewQuery() { | ||||||||
| const router = useRouter(); | ||||||||
| const queryClient = useQueryClient(); | ||||||||
|
|
||||||||
| return useMutation({ | ||||||||
| mutationFn: (data: CreateCrewRequestTypes) => createCrew(data), | ||||||||
| onSuccess: (data) => { | ||||||||
| if (data === null || data === undefined) { | ||||||||
| return; | ||||||||
| } | ||||||||
| queryClient.invalidateQueries({ queryKey: ['crewLists', 'crewDetail'] }); | ||||||||
|
There was a problem hiding this comment. 쿼리 무효화 시 올바른 사용법 적용
수정 제안: -queryClient.invalidateQueries({ queryKey: ['crewLists', 'crewDetail'] });
+queryClient.invalidateQueries(['crewLists']);
+queryClient.invalidateQueries(['crewDetail']);📝 Committable suggestion
Suggested change
|
||||||||
| toast.success('크루가 생성되었습니다.'); | ||||||||
| router.push(`/crew/detail/${data.crewId}`); | ||||||||
| }, | ||||||||
| onError: (error) => { | ||||||||
| toast.error(error.message); | ||||||||
| }, | ||||||||
| }); | ||||||||
| } | ||||||||
|
|
||||||||
| export function useEditCrewQuery(id: number) { | ||||||||
| const router = useRouter(); | ||||||||
| const queryClient = useQueryClient(); | ||||||||
|
|
||||||||
| return useMutation({ | ||||||||
| mutationFn: (data: EditCrewRequestTypes) => editCrew(id, data), | ||||||||
| onSuccess: () => { | ||||||||
| queryClient.invalidateQueries({ queryKey: ['crewDetail'] }); | ||||||||
|
There was a problem hiding this comment. 🛠️ Refactor suggestion 쿼리 무효화 시 정확한 키 사용 현재 수정 제안: -queryClient.invalidateQueries({ queryKey: ['crewDetail'] });
+queryClient.invalidateQueries(['crewDetail', id]);
|
||||||||
| toast.success('크루 정보가 수정되었습니다.'); | ||||||||
| if (router) { | ||||||||
| router.push(`/crew/detail/${id}`); | ||||||||
| } | ||||||||
| }, | ||||||||
| onError: (error) => { | ||||||||
| toast.error(error.message); | ||||||||
| }, | ||||||||
| retry: false, | ||||||||
| }); | ||||||||
| } | ||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,22 +6,22 @@ import { useInfiniteScroll } from '@/src/hooks/use-infinite-scroll'; | |
| import CrewCardList from '@/src/components/common/crew-list/crew-card-list'; | ||
|
|
||
| export default function MyCrewHostedPage() { | ||
| const { data, isLoading, error, ref, isFetchingNextPage } = useInfiniteScroll( | ||
| useGetMyCrewHostedQuery({ | ||
| pageable: { page: 0, size: 6, sort: ['createdAt,desc'] }, | ||
| }), | ||
| ); | ||
| return ( | ||
| <div> | ||
| <CrewCardList inWhere="my-crew" data={data ?? { pages: [], pageParams: [] }} /> | ||
| {isLoading || isFetchingNextPage ? ( | ||
| <div className="flex justify-center py-10"> | ||
| <Loader size="sm" /> | ||
| </div> | ||
| ) : ( | ||
| <div ref={ref} className="h-[1px]" /> | ||
| )} | ||
| {error && <p className="py-10 text-center">에러가 발생했습니다.</p>} | ||
| </div> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -6,22 +6,22 @@ import { useInfiniteScroll } from '@/src/hooks/use-infinite-scroll'; | |||||||||||||||||||||||||
| import CrewCardList from '@/src/components/common/crew-list/crew-card-list'; | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| export default function MyCrewJoinedPage() { | ||||||||||||||||||||||||||
| const { data, isLoading, error, ref, isFetchingNextPage } = useInfiniteScroll( | ||||||||||||||||||||||||||
| useGetMyCrewJoinedQuery({ | ||||||||||||||||||||||||||
| pageable: { page: 0, size: 6, sort: ['createdAt,desc'] }, | ||||||||||||||||||||||||||
| }), | ||||||||||||||||||||||||||
| ); | ||||||||||||||||||||||||||
| return ( | ||||||||||||||||||||||||||
| <div> | ||||||||||||||||||||||||||
| <CrewCardList inWhere="my-crew" data={data ?? { pages: [], pageParams: [] }} /> | ||||||||||||||||||||||||||
| {isLoading || isFetchingNextPage ? ( | ||||||||||||||||||||||||||
| <div className="flex justify-center py-10"> | ||||||||||||||||||||||||||
| <Loader size="sm" /> | ||||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||||
| ) : ( | ||||||||||||||||||||||||||
| <div ref={ref} className="h-[1px]" /> | ||||||||||||||||||||||||||
| )} | ||||||||||||||||||||||||||
| {error && <p className="py-10 text-center">에러가 발생했습니다.</p>} | ||||||||||||||||||||||||||
|
There was a problem hiding this comment. 🛠️ Refactor suggestion 에러 처리를 더 상세하게 개선하면 좋겠습니다. 현재는 일반적인 에러 메시지만 표시되고 있습니다. 사용자에게 더 구체적인 정보와 해결 방법을 제공하면 좋을 것 같습니다. 다음과 같이 개선해보세요: - {error && <p className="py-10 text-center">에러가 발생했습니다.</p>}
+ {error && (
+ <div className="py-10 text-center">
+ <p className="text-red-500 mb-2">데이터를 불러오는 중 문제가 발생했습니다.</p>
+ <button
+ onClick={() => window.location.reload()}
+ className="text-blue-500 underline"
+ >
+ 다시 시도하기
+ </button>
+ </div>
+ )}📝 Committable suggestion
Suggested change
|
||||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||||
| ); | ||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,7 +35,7 @@ export default function HomePage() { | |
| } | ||
| }; | ||
|
|
||
| const { data, isLoading, error, isFetchingNextPage, ref } = useInfiniteScroll( | ||
| useGetCrewListQuery({ | ||
| condition: { | ||
| keyword: search, | ||
|
|
@@ -133,14 +133,14 @@ export default function HomePage() { | |
| </div> | ||
| <div className="mt-8 px-3 md:px-8 lg:px-11.5"> | ||
| {data && <CrewCardList data={data} />} | ||
| {isLoading || isFetchingNextPage ? ( | ||
| <div className="flex justify-center py-10"> | ||
| <Loader size="sm" /> | ||
| </div> | ||
| ) : ( | ||
| <div ref={ref} className="h-[1px]" /> | ||
| )} | ||
| {error && <p className="py-10 text-center">에러가 발생했습니다.</p>} | ||
|
There was a problem hiding this comment. 🛠️ Refactor suggestion 에러 처리를 더 자세하게 개선해 주세요. 현재 에러 메시지가 너무 단순합니다. 사용자에게 더 구체적인 정보와 문제 해결 방법을 제공하면 좋겠습니다. - {error && <p className="py-10 text-center">에러가 발생했습니다.</p>}
+ {error && (
+ <div className="flex flex-col items-center py-10 text-center">
+ <p className="mb-2 text-red-500">데이터를 불러오는 중 문제가 발생했습니다.</p>
+ <p className="mb-4 text-sm text-gray-600">잠시 후 다시 시도해 주세요.</p>
+ <Button
+ onClick={() => window.location.reload()}
+ className="btn-filled px-4 py-2 text-sm"
+ >
+ 새로고침
+ </Button>
+ </div>
+ )}
|
||
| </div> | ||
| </div> | ||
| ); | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
editCrew 함수의 구현을 개선해야 합니다.
다음과 같은 중요한 개선사항들이 필요합니다:
다음과 같이 수정하는 것을 제안드립니다:
🧰 Tools
🪛 Biome
[error] 40-40: The catch clause that only rethrows the original error is useless.
An unnecessary catch clause can be confusing.
Unsafe fix: Remove the try/catch clause.
(lint/complexity/noUselessCatch)