Feat/138/profile card #140
Conversation
Walkthrough์ด ๋ณ๊ฒฝ ์ฌํญ์ Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the toolโs configuration or disable the tool if itโs a critical failure. ๐ง eslint
src/app/(crew)/crew/detail/[id]/_components/gathering-list-section.tsxOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't determine the plugin "react-hooks" uniquely.
Please remove the "plugins" setting from either config or remove either plugin installation. If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? ๐ชง TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
๐storybook: https://67206cc6ff9d7a05a3528ff8-prafqmdmmj.chromatic.com/ |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
๐งน Outside diff range and nitpick comments (5)
src/app/(crew)/my-page/_components/profile-card/container.tsx (2)
20-33: ์ธ์ฆ ๋ก์ง์ ๋์ฑ ๊ฐ๋จํ๊ฒ ๊ฐ์ ํ ์ ์์ต๋๋ค.ํ์ฌ ๊ตฌํ์ ์ ์๋ํ์ง๋ง, ์กฐ๊ฑด๋ฌธ์ ๋จ์ํํ์ฌ ๊ฐ๋ ์ฑ์ ๋์ผ ์ ์์ต๋๋ค.
๋ค์๊ณผ ๊ฐ์ด ๊ฐ์ ํด๋ณด์ธ์:
useEffect(() => { if (userLoading) return; - if (user) { - setIsAuthChecked(true); - } else if (!isAuth) { + if (!isAuth && !user) { toast.error('๋ก๊ทธ์ธ์ด ํ์ํฉ๋๋ค.'); router.push('/login'); - } else { - setIsAuthChecked(true); + return; } + setIsAuthChecked(true); }, [user, userLoading, isAuth, router]);
41-42: ๋ก๋ฉ ์ํ UI๋ฅผ ๊ฐ์ ํ๋ฉด ์ข๊ฒ ์ต๋๋ค.ํ์ฌ๋ ๋จ์ํ ํ ์คํธ๋ก ๋ก๋ฉ ์ํ๋ฅผ ํ์ํ๊ณ ์์ต๋๋ค. ์ฌ์ฉ์ ๊ฒฝํ ํฅ์์ ์ํด ์ค์ผ๋ ํค UI๋ ์คํผ๋๋ฅผ ์ฌ์ฉํ๋ ๊ฒ์ ์ถ์ฒ๋๋ฆฝ๋๋ค.
์์:
import { Skeleton } from '@/components/ui/skeleton'; // ... if (userLoading || !isAuthChecked) { return ( <div className="w-full p-4 space-y-4"> <Skeleton className="h-12 w-12 rounded-full" /> <Skeleton className="h-4 w-[250px]" /> <Skeleton className="h-4 w-[200px]" /> </div> ); }src/app/(crew)/crew/detail/[id]/_components/gathering-list-section.tsx (3)
47-52: ๋ก๋ฉ ์ํ UI ๊ฐ์ ์ด ํ์ํฉ๋๋คํ์ฌ ๊ตฌํ๋ ๋ก๋ฉ ์ํ๋ ๊ธฐ๋ณธ์ ์ธ ํ ์คํธ๋ง ํ์ํ๊ณ ์์ต๋๋ค. ์ฌ์ฉ์ ๊ฒฝํ ํฅ์์ ์ํด ์คํผ๋๋ ์ค์ผ๋ ํค UI๋ฅผ ์ถ๊ฐํ๋ ๊ฒ์ด ์ข๊ฒ ์ต๋๋ค.
๋ค์๊ณผ ๊ฐ์ด ๊ฐ์ ํด๋ณด์ธ์:
if (isLoading) return ( <div className="flex items-center justify-center"> - <p>๋ก๋ฉ ์ค...</p> + <div role="status" className="animate-pulse"> + <div className="h-4 bg-gray-200 rounded-full w-48 mb-4"></div> + <span className="sr-only">๋ก๋ฉ ์ค...</span> + </div> </div> );
61-66: ๋น ์ํ UI๋ฅผ ๊ฐ์ ํด์ฃผ์ธ์ํ์ฌ ๋น ์ํ ๋ฉ์์ง๊ฐ ๋๋ฌด ๋จ์ํฉ๋๋ค. ์ฌ์ฉ์์๊ฒ ๋ ์น๊ทผํ๊ณ ์๋ด๊ฐ ๋๋ ๋ฉ์์ง๋ฅผ ์ ๊ณตํ๋ฉด ์ข๊ฒ ์ต๋๋ค.
๋ค์๊ณผ ๊ฐ์ด ๊ฐ์ ํด๋ณด์ธ์:
if (!gatheringList || gatheringList.length === 0) return ( <div className="flex items-center justify-center"> - <p>๋ฐ์ดํฐ๊ฐ ์์ต๋๋ค.</p> + <div className="text-center p-8"> + <p className="text-lg mb-2">์์ง ๋ฑ๋ก๋ ๋ชจ์์ด ์์ต๋๋ค</p> + <p className="text-sm text-gray-600"> + ์๋ก์ด ๋ชจ์์ด ๋ฑ๋ก๋๋ฉด ์ด๊ณณ์์ ํ์ธํ์ค ์ ์์ต๋๋ค + </p> + </div> </div> );
47-47: TODO ์ฃผ์์ ํด๊ฒฐํด์ฃผ์ธ์"์ถํ ์๋ฌ, ๋ก๋ฉ ์์ " TODO ์ฃผ์์ด ์์ต๋๋ค. ์ด ์์ ์ ์ถ์ ํ๊ณ ๊ด๋ฆฌํ ์ ์๋๋ก ์ด์๋ก ๋ฑ๋กํ๋ ๊ฒ์ด ์ข๊ฒ ์ต๋๋ค.
์ด TODO ํญ๋ชฉ์ GitHub ์ด์๋ก ์์ฑํด๋๋ฆด๊น์?
๐ Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
๐ Files selected for processing (2)
src/app/(crew)/crew/detail/[id]/_components/gathering-list-section.tsx(1 hunks)src/app/(crew)/my-page/_components/profile-card/container.tsx(3 hunks)
๐ Additional comments (2)
src/app/(crew)/my-page/_components/profile-card/container.tsx (2)
18-18: useUser ํ
์ฌ์ฉ์ด ๊ฐ์ ๋์์ต๋๋ค!
loading ์ํ์ ๋ฐ์ดํฐ ๊ฐฑ์ ๊ธฐ๋ฅ์ ์ถ๊ฐํ์ฌ ์ฌ์ฉ์ ๊ฒฝํ์ด ํฅ์๋์์ต๋๋ค.
35-39: ํ๋กํ ์ด๋ฏธ์ง URL ๊ด๋ฆฌ๊ฐ ์ ๋ถ๋ฆฌ๋์์ต๋๋ค!
์ฌ์ฉ์ ๋ฐ์ดํฐ ๋ณ๊ฒฝ์ ๋ฐ๋ฅธ ์ด๋ฏธ์ง URL ์ ๋ฐ์ดํธ ๋ก์ง์ด ๊น๋ํ๊ฒ ๋ถ๋ฆฌ๋์์ต๋๋ค.
| await refetchUser(); | ||
| toast.success('ํ๋กํ ์ด๋ฏธ์ง๊ฐ ์ ๋ฐ์ดํธ๋์์ต๋๋ค.'); |
There was a problem hiding this comment.
ํ์ผ ์ ๋ก๋ ๋ณด์์ ๊ฐํํด์ฃผ์ธ์.
ํ์ผ ํฌ๊ธฐ ๊ฒ์ฆ์ ์ ๋์ด์์ง๋ง, ํ์ผ ํ์์ ๋ํ ์ถ๊ฐ ๊ฒ์ฆ์ด ํ์ํฉ๋๋ค.
๋ค์๊ณผ ๊ฐ์ด ํ์ผ ํ์ ๊ฒ์ฆ์ ์ถ๊ฐํด์ฃผ์ธ์:
input.onchange = async (event) => {
const file = (event.target as HTMLInputElement)?.files?.[0];
if (file) {
+ const validTypes = ['image/jpeg', 'image/png', 'image/jpg'];
+ if (!validTypes.includes(file.type)) {
+ toast.error('PNG, JPG ํ์์ ์ด๋ฏธ์ง๋ง ์
๋ก๋ ๊ฐ๋ฅํฉ๋๋ค.');
+ return;
+ }
if (file.size > 5 * 1024 * 1024) {
alert('5MB ์ดํ์ ํ์ผ๋ง ์
๋ก๋ ๊ฐ๋ฅํฉ๋๋ค.');
return;
}Also applies to: 75-75
| if (error) | ||
| return ( | ||
| <div className="flex items-center justify-center"> | ||
| <p>๋ฐ์ดํฐ๋ฅผ ๋ถ๋ฌ์ค๋ ๋ฐ ์คํจํ์ต๋๋ค</p> | ||
| </div> | ||
| ); |
There was a problem hiding this comment.
๐ ๏ธ Refactor suggestion
์๋ฌ ๋ฉ์์ง๋ฅผ ๋ ๊ตฌ์ฒด์ ์ผ๋ก ํ์ํด์ฃผ์ธ์
ํ์ฌ ์๋ฌ ๋ฉ์์ง๊ฐ ๋๋ฌด ์ผ๋ฐ์ ์ ๋๋ค. ์ฌ์ฉ์๊ฐ ๋ฌธ์ ๋ฅผ ์ดํดํ๊ณ ๋์ฒํ ์ ์๋๋ก ๋ ๊ตฌ์ฒด์ ์ธ ์ ๋ณด๋ฅผ ์ ๊ณตํด์ผ ํฉ๋๋ค.
๋ค์๊ณผ ๊ฐ์ด ๊ฐ์ ํด๋ณด์ธ์:
if (error)
return (
<div className="flex items-center justify-center">
- <p>๋ฐ์ดํฐ๋ฅผ ๋ถ๋ฌ์ค๋ ๋ฐ ์คํจํ์ต๋๋ค</p>
+ <div className="text-center">
+ <p className="text-red-500 mb-2">๋ฐ์ดํฐ๋ฅผ ๋ถ๋ฌ์ค๋ ๋ฐ ์คํจํ์ต๋๋ค</p>
+ <p className="text-sm text-gray-600">
+ {error instanceof Error ? error.message : '์ ์ ํ ๋ค์ ์๋ํด์ฃผ์ธ์'}
+ </p>
+ </div>
</div>
);๐ Committable suggestion
โผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| if (error) | |
| return ( | |
| <div className="flex items-center justify-center"> | |
| <p>๋ฐ์ดํฐ๋ฅผ ๋ถ๋ฌ์ค๋ ๋ฐ ์คํจํ์ต๋๋ค</p> | |
| </div> | |
| ); | |
| if (error) | |
| return ( | |
| <div className="flex items-center justify-center"> | |
| <div className="text-center"> | |
| <p className="text-red-500 mb-2">๋ฐ์ดํฐ๋ฅผ ๋ถ๋ฌ์ค๋ ๋ฐ ์คํจํ์ต๋๋ค</p> | |
| <p className="text-sm text-gray-600"> | |
| {error instanceof Error ? error.message : '์ ์ ํ ๋ค์ ์๋ํด์ฃผ์ธ์'} | |
| </p> | |
| </div> | |
| </div> | |
| ); |
There was a problem hiding this comment.
Actionable comments posted: 1
๐งน Outside diff range and nitpick comments (7)
src/app/(crew)/my-page/_components/profile-card/container.tsx (4)
20-33: ์ธ์ฆ ๋ก์ง ๊ฐ์ ์ ์ํ์ฌ ๊ตฌํ์ ์ ์๋ํ์ง๋ง, ๋ค์๊ณผ ๊ฐ์ด ๋ ๊ฐ๋จํ๊ฒ ๋ฆฌํฉํ ๋งํ ์ ์์ต๋๋ค:
- const [isAuthChecked, setIsAuthChecked] = useState(false); useEffect(() => { if (userLoading) return; - if (user) { - setIsAuthChecked(true); - } else if (!isAuth) { + if (!isAuth && !user) { toast.error('๋ก๊ทธ์ธ์ด ํ์ํฉ๋๋ค.'); router.push('/login'); - } else { - setIsAuthChecked(true); } }, [user, userLoading, isAuth, router]);
35-39: ํ๋กํ ์ด๋ฏธ์ง ์ํ ๊ด๋ฆฌ ๊ฐ์ ์ ์useEffect ๋ด์์ ์ด์ ํ๋กํ ์ด๋ฏธ์ง URL์ ๋ํ ๋ฉ๋ชจ๋ฆฌ ์ ๋ฆฌ๊ฐ ํ์ํ ์ ์์ต๋๋ค.
useEffect(() => { if (user?.profileImageUrl) { setProfileImageUrl(user.profileImageUrl); } + return () => { + if (profileImageUrl.startsWith('blob:')) { + URL.revokeObjectURL(profileImageUrl); + } + }; }, [user]);
41-42: ๋ก๋ฉ ์ํ ํ์ ๊ฐ์ ์ ์์ฌ์ฉ์ ๊ฒฝํ ํฅ์์ ์ํด ๋ก๋ฉ ์ํ์ ์ค์ผ๋ ํค UI๋ ์คํผ๋๋ฅผ ์ถ๊ฐํ๋ ๊ฒ์ด ์ข์ต๋๋ค.
- if (userLoading || !isAuthChecked) return <div>๋ก๋ฉ ์ค...</div>; + if (userLoading || !isAuthChecked) return <ProfileCardSkeleton />;
62-63: ์๋ฌ ์ฒ๋ฆฌ ๊ฐ์ ์ ์์๋ฌ ๋ฉ์์ง๋ฅผ ๋ ๊ตฌ์ฒด์ ์ผ๋ก ์ ๊ณตํ์ฌ ์ฌ์ฉ์๊ฐ ๋ฌธ์ ๋ฅผ ๋ ์ ์ดํดํ ์ ์๋๋ก ํ๋ฉด ์ข๊ฒ ์ต๋๋ค.
try { await updateUserProfile(file); await refetchUser(); toast.success('ํ๋กํ ์ด๋ฏธ์ง๊ฐ ์ ๋ฐ์ดํธ๋์์ต๋๋ค.'); } catch (error) { - toast.error('ํ์ผ ์ ๋ก๋์ ์คํจํ์ต๋๋ค.'); + const errorMessage = error instanceof Error ? error.message : 'ํ์ผ ์ ๋ก๋์ ์คํจํ์ต๋๋ค.'; + toast.error(`ํ๋กํ ์ ๋ฐ์ดํธ ์คํจ: ${errorMessage}`); }Also applies to: 75-75
src/app/(crew)/crew/detail/[id]/_components/gathering-list-section.tsx (3)
46-46: TODO ์ฝ๋ฉํธ ์ฒ๋ฆฌ ํ์ํ์ฌ ์๋ฌ์ ๋ก๋ฉ ์ํ์ ๋ํ ๊ฐ์ ์ด ํ์ํ๋ค๋ TODO ์ฝ๋ฉํธ๊ฐ ์์ต๋๋ค. ๋ค์๊ณผ ๊ฐ์ ๊ฐ์ ์ฌํญ์ ์ ์๋๋ฆฝ๋๋ค:
- ๋ก๋ฉ ์ํ: ์ค์ผ๋ ํค UI ๊ตฌํ
- ์๋ฌ ์ฒ๋ฆฌ: React Error Boundary ๋์
์ด๋ฌํ ๊ฐ์ ์ฌํญ์ ๋ํ ๊ตฌํ์ ๋์๋๋ฆด๊น์?
47-52: ๋ก๋ฉ ์ํ UI ๊ฐ์ ์ ์ํ์ฌ ๊ตฌํ๋ ๋ก๋ฉ ์ํ์ ์ค์ ์ ๋ ฌ์ ์ข์ ๊ฐ์ ์ด์ง๋ง, ์ฌ์ฉ์ ๊ฒฝํ์ ๋์ฑ ํฅ์์ํฌ ์ ์์ต๋๋ค.
๋ค์๊ณผ ๊ฐ์ ๊ฐ์ ์ ์ ์๋๋ฆฝ๋๋ค:
- <div className="flex items-center justify-center"> - <p>๋ก๋ฉ ์ค...</p> + <div className="flex items-center justify-center min-h-[200px]"> + <div className="flex flex-col items-center gap-2"> + <div className="animate-spin rounded-full h-8 w-8 border-b-2 border-primary" /> + <p className="text-gray-600">๋ก๋ฉ ์ค...</p> + </div> </div>
61-66: ๋น ์ํ UI ๊ฐ์ ์ ์ํ์ฌ ๋น ์ํ ๋ฉ์์ง๊ฐ ๋๋ฌด ๋จ์ํฉ๋๋ค. ์ฌ์ฉ์์๊ฒ ๋ ์ ์ฉํ ์ ๋ณด๋ฅผ ์ ๊ณตํ ์ ์์ต๋๋ค.
๋ค์๊ณผ ๊ฐ์ ๊ฐ์ ์ ์ ์๋๋ฆฝ๋๋ค:
- <div className="flex items-center justify-center"> - <p>๋ฐ์ดํฐ๊ฐ ์์ต๋๋ค.</p> + <div className="flex items-center justify-center min-h-[200px]"> + <div className="flex flex-col items-center gap-2 text-center"> + <svg className="w-16 h-16 text-gray-400" fill="none" stroke="currentColor" viewBox="0 0 24 24"> + <path strokeLinecap="round" strokeLinejoin="round" strokeWidth="2" d="M20 13V6a2 2 0 00-2-2H6a2 2 0 00-2 2v7m16 0v5a2 2 0 01-2 2H6a2 2 0 01-2-2v-5m16 0h-2.586a1 1 0 00-.707.293l-2.414 2.414a1 1 0 01-.707.293h-3.172a1 1 0 01-.707-.293l-2.414-2.414A1 1 0 006.586 13H4" /> + </svg> + <p className="text-lg font-semibold">์์ง ๋ฑ๋ก๋ ๋ชจ์์ด ์์ต๋๋ค</p> + <p className="text-sm text-gray-600">์๋ก์ด ๋ชจ์์ด ๋ฑ๋ก๋๋ฉด ์ด๊ณณ์์ ํ์ธํ์ค ์ ์์ต๋๋ค</p> + </div> + </div>
๐ Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
๐ Files selected for processing (2)
src/app/(crew)/crew/detail/[id]/_components/gathering-list-section.tsx(1 hunks)src/app/(crew)/my-page/_components/profile-card/container.tsx(3 hunks)
๐ Additional comments (1)
src/app/(crew)/my-page/_components/profile-card/container.tsx (1)
18-18: ๋ฐ์ดํฐ ๊ด๋ฆฌ ๊ฐ์ ์ด ์ ์ด๋ฃจ์ด์ก์ต๋๋ค!
useUser ํ ์์ refetch ๊ธฐ๋ฅ์ ์ถ๊ฐํ์ฌ ๋ฐ์ดํฐ ๋๊ธฐํ ๊ธฐ๋ฅ์ด ๊ฐ์ ๋์์ต๋๋ค.
| if (error) | ||
| return ( | ||
| <div className="flex items-center justify-center"> | ||
| <p>๋ฐ์ดํฐ๋ฅผ ๋ถ๋ฌ์ค๋ ๋ฐ ์คํจํ์ต๋๋ค</p> | ||
| </div> | ||
| ); |
There was a problem hiding this comment.
๐ ๏ธ Refactor suggestion
์๋ฌ ์ํ ์ฒ๋ฆฌ ๊ฐ์ ํ์
์๋ฌ ๋ฉ์์ง๊ฐ ๋๋ฌด ์ผ๋ฐ์ ์ด๋ฉฐ, ์ฌ์ฉ์์๊ฒ ์ถฉ๋ถํ ์ ๋ณด๋ ํด๊ฒฐ ๋ฐฉ๋ฒ์ ์ ๊ณตํ์ง ์์ต๋๋ค.
๋ค์๊ณผ ๊ฐ์ ๊ฐ์ ์ ์ ์๋๋ฆฝ๋๋ค:
- <div className="flex items-center justify-center">
- <p>๋ฐ์ดํฐ๋ฅผ ๋ถ๋ฌ์ค๋ ๋ฐ ์คํจํ์ต๋๋ค</p>
+ <div className="flex items-center justify-center min-h-[200px]">
+ <div className="flex flex-col items-center gap-4">
+ <p className="text-red-500">๋ฐ์ดํฐ๋ฅผ ๋ถ๋ฌ์ค๋ ๋ฐ ์คํจํ์ต๋๋ค</p>
+ <p className="text-sm text-gray-600">{error instanceof Error ? error.message : '์ ์ ์๋ ์ค๋ฅ๊ฐ ๋ฐ์ํ์ต๋๋ค'}</p>
+ <button
+ onClick={() => window.location.reload()}
+ className="px-4 py-2 bg-primary text-white rounded-md hover:bg-primary-dark"
+ >
+ ๋ค์ ์๋
+ </button>
+ </div>
+ </div>๐ Committable suggestion
โผ๏ธ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| if (error) | |
| return ( | |
| <div className="flex items-center justify-center"> | |
| <p>๋ฐ์ดํฐ๋ฅผ ๋ถ๋ฌ์ค๋ ๋ฐ ์คํจํ์ต๋๋ค</p> | |
| </div> | |
| ); | |
| if (error) | |
| return ( | |
| <div className="flex items-center justify-center min-h-[200px]"> | |
| <div className="flex flex-col items-center gap-4"> | |
| <p className="text-red-500">๋ฐ์ดํฐ๋ฅผ ๋ถ๋ฌ์ค๋ ๋ฐ ์คํจํ์ต๋๋ค</p> | |
| <p className="text-sm text-gray-600">{error instanceof Error ? error.message : '์ ์ ์๋ ์ค๋ฅ๊ฐ ๋ฐ์ํ์ต๋๋ค'}</p> | |
| <button | |
| onClick={() => window.location.reload()} | |
| className="px-4 py-2 bg-primary text-white rounded-md hover:bg-primary-dark" | |
| > | |
| ๋ค์ ์๋ | |
| </button> | |
| </div> | |
| </div> | |
| ); |
minkyung5x5
left a comment
minkyung5x5
left a comment
There was a problem hiding this comment.
์๊ณ ํ์ จ์ต๋๋ท!
ChoYenii
left a comment
ChoYenii
left a comment
There was a problem hiding this comment.
์๊ณ ๋ง์ผ์ จ์ต๋๋ค!
๐ Issue Ticket
#138
โ๏ธ Description
โ Checklist
PR
Test
Summary by CodeRabbit
์๋ก์ด ๊ธฐ๋ฅ
GatheringListSection์ปดํฌ๋ํธ์ ๋ก๋ฉ ๋ฐ ์ค๋ฅ ์ํ ์๊ฐ์ ํํ ๊ฐ์ .ProfileCard์ปดํฌ๋ํธ์ ์ฌ์ฉ์ ๋ฐ์ดํฐ ๋ก๋ฉ ๋ฐ ์๋ก ๊ณ ์นจ ๊ธฐ๋ฅ ๊ฐํ.๋ฒ๊ทธ ์์