-
Notifications
You must be signed in to change notification settings - Fork 3
Fix/youl bug fix #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/youl bug fix #150
Changes from 21 commits
6b7ea7c
3257b25
536f3b2
17d4514
59ac630
e0e83ee
0878802
ff82386
f8f4f95
52eb474
013fde3
8ecaabf
fef8165
fea5c28
de86036
4dc9e50
3ce5331
cbb4d4e
2656c9c
43a4179
43fd284
9260be9
96f1e22
0a5ab41
5e014cf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -88,9 +88,7 @@ export default function CreateGatheringForm({ | |
| /> | ||
| </div> | ||
| <div className="flex flex-col gap-3"> | ||
| <label htmlFor="gathering-image" className="text-base font-semibold text-gray-800"> | ||
| μ΄λ―Έμ§ μ ν/μ²¨λΆ | ||
| </label> | ||
| <span className="text-base font-semibold text-gray-800">μ΄λ―Έμ§ μ ν/첨λΆ</span> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. μ κ·Όμ± κ°μ μ μν΄ μλ―Έλ‘ μ νκ·Έ μ¬μ© νμ μ΄λ―Έμ§ μ ν λ μ΄λΈμ΄ λ€μκ³Ό κ°μ΄ μμ νλ κ²μ μ μν©λλ€: -<span className="text-base font-semibold text-gray-800">μ΄λ―Έμ§ μ ν/첨λΆ</span>
+<label htmlFor="gathering-image" className="text-base font-semibold text-gray-800">μ΄λ―Έμ§ μ ν/첨λΆ</label>
|
||
| <div className="flex"> | ||
| <Controller | ||
| name="imageUrl" | ||
|
|
@@ -161,9 +159,7 @@ export default function CreateGatheringForm({ | |
| </div> | ||
| <div className="flex flex-col gap-3"> | ||
| <div className="flex justify-between"> | ||
| <label htmlFor="gathering-dateTime" className="text-base font-semibold text-gray-800"> | ||
| λ μ§ | ||
| </label> | ||
| <span className="text-base font-semibold text-gray-800">λ μ§</span> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. λ μ§ μ ν λ μ΄λΈμ μλ―Έλ‘ μ λ§ν¬μ κ°μ νμ λ μ§ μ ν λ μ΄λΈλ λ€μκ³Ό κ°μ΄ μμ νλ κ²μ μ μν©λλ€: -<span className="text-base font-semibold text-gray-800">λ μ§</span>
+<label htmlFor="gathering-datetime" className="text-base font-semibold text-gray-800">λ μ§</label>
|
||
| </div> | ||
| <Controller | ||
| name="dateTime" | ||
|
|
@@ -223,6 +219,7 @@ export default function CreateGatheringForm({ | |
| render={({ field }) => ( | ||
| <Textarea | ||
| {...field} | ||
| id="gathering-introduce" | ||
| placeholder="λͺ¨μ§ μ€λͺ /곡μ§λ₯Ό 100μ μ΄λ΄λ‘ μ λ ₯ν΄μ£ΌμΈμ." | ||
| maxLength={100} | ||
| inputClassNames="h-40 py-2.5 px-4 bg-gray-100 placeholder:text-gray-400 font-pretendard text-base font-medium rounded-xl" | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ import { theme } from '@/src/styles/theme'; | |
|
|
||
| export const metadata: Metadata = { | ||
| title: 'CrewCrew', | ||
| description: 'Generated by CODEIT TEAM1', | ||
| description: 'λ΄ ν¬λ£¨μ ν¨κ» μ½μνκ³ λ§λλ μ΄λ μλͺ¨μ μΉμ¬μ΄νΈ', | ||
| }; | ||
|
|
||
| export default function RootLayout({ | ||
|
|
@@ -20,6 +20,13 @@ export default function RootLayout({ | |
| return ( | ||
| <html lang="en" className={pretendard.variable}> | ||
| <head> | ||
| <meta property="og:image" content="/assets/images/og.png" /> | ||
| <meta property="og:title" content="CrewCrew" /> | ||
| <meta | ||
| property="og:description" | ||
| content="λ΄ ν¬λ£¨μ ν¨κ» μ½μνκ³ λ§λλ μ΄λ μλͺ¨μ μΉμ¬μ΄νΈ" | ||
| /> | ||
| <meta property="og:url" content="https://crewcrew.vercel.app" /> | ||
|
Comment on lines
+24
to
+30
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. π‘ Codebase verification Open Graph λ©ν νκ·Έ μ€μ μ΄ λΆλΆμ μΌλ‘ νμΈλμμ΅λλ€.
π Analysis chainOpen Graph λ©ν νκ·Έ μ€μ μ νμΈν΄μ£ΌμΈμ. λ€μ μ¬νλ€μ κ²μ¦ν΄μ£ΌμκΈ° λ°λλλ€:
π Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# og:image νμΌ μ‘΄μ¬ μ¬λΆ νμΈ
fd "og.png" public/assets/images
# og:url μ€μ κ΄λ ¨ νκ²½ λ³μ μ¬μ© μ¬λΆ νμΈ
rg -A 2 "NEXT_PUBLIC.*URL|VERCEL_URL" .env*
Length of output: 154 Script: #!/bin/bash
# Check if there are any environment-related configurations in the codebase
rg -g "!{.git,node_modules}" "process\.env|NEXT_PUBLIC|VERCEL_URL"
# Check if there are any URL configurations in Next.js config files
fd -e config.js -e config.ts | xargs cat
# Look for any environment configuration patterns in the codebase
ast-grep --pattern 'process.env.$_'
Length of output: 6571 |
||
| <ColorSchemeScript /> | ||
| </head> | ||
| <body> | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -50,7 +50,13 @@ export default function ReviewableGatheringCard({ | |||||||||||||||||||||||||||
| return ( | ||||||||||||||||||||||||||||
| <div className="flex w-full max-w-[1200px] gap-[20px] border-b-[2px] border-b-gray-200 py-[24px]"> | ||||||||||||||||||||||||||||
| <span className="relative h-[166px] w-[294px] overflow-hidden rounded-[12px]"> | ||||||||||||||||||||||||||||
| <Image src={imageUrl} alt={gatheringName} fill /> | ||||||||||||||||||||||||||||
| <Image | ||||||||||||||||||||||||||||
| src={imageUrl} | ||||||||||||||||||||||||||||
| alt={gatheringName} | ||||||||||||||||||||||||||||
| fill | ||||||||||||||||||||||||||||
| sizes="(max-width: 744px) 100vw, (max-width: 1200px) 50vw, 33vw" | ||||||||||||||||||||||||||||
| className="h-full w-full object-cover" | ||||||||||||||||||||||||||||
| /> | ||||||||||||||||||||||||||||
| </span> | ||||||||||||||||||||||||||||
| <div className="flex w-full items-end justify-between"> | ||||||||||||||||||||||||||||
| <div className="flex h-full flex-col items-start justify-between"> | ||||||||||||||||||||||||||||
|
|
@@ -60,7 +66,13 @@ export default function ReviewableGatheringCard({ | |||||||||||||||||||||||||||
| </div> | ||||||||||||||||||||||||||||
| <div className="flex w-fit items-center"> | ||||||||||||||||||||||||||||
| <span className="relative inline-block h-[20px] w-[20px]"> | ||||||||||||||||||||||||||||
| <Image alt="μ°Έμ¬ μΈμ" src={person} fill /> | ||||||||||||||||||||||||||||
| <Image | ||||||||||||||||||||||||||||
| alt="μ°Έμ¬ μΈμ" | ||||||||||||||||||||||||||||
| src={person} | ||||||||||||||||||||||||||||
| fill | ||||||||||||||||||||||||||||
| sizes="(max-width: 744px) 100vw, (max-width: 1200px) 50vw, 33vw" | ||||||||||||||||||||||||||||
| className="h-full w-full object-contain" | ||||||||||||||||||||||||||||
| /> | ||||||||||||||||||||||||||||
|
Comment on lines
+69
to
+75
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. π οΈ Refactor suggestion μμ΄μ½ μ΄λ―Έμ§ μ΅μ ν νμ μμ μμ΄μ½ μ΄λ―Έμ§μ λΆνμν λ°μν μμ±μ΄ μ μ©λμ΄ μμ΅λλ€. κ³ μ ν¬κΈ°μ μμ΄μ½μ΄λ―λ‘ <Image
alt="μ°Έμ¬ μΈμ"
src={person}
fill
- sizes="(max-width: 744px) 100vw, (max-width: 1200px) 50vw, 33vw"
className="h-full w-full object-contain"
/>π Committable suggestion
Suggested change
|
||||||||||||||||||||||||||||
| </span> | ||||||||||||||||||||||||||||
| <span className="mr-[22px] text-base font-medium text-gray-700"> | ||||||||||||||||||||||||||||
| {currentCount}/{totalCount} | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π οΈ Refactor suggestion
μ΄λ―Έμ§ μ ν UIμ μλ§¨ν± λ§ν¬μ κ°μ μ΄ νμν©λλ€.
labelμ리먼νΈλ₯ΌspanμΌλ‘ λ³κ²½νλ©΄ μ κ·Όμ±μ΄ μ νλ μ μμ΅λλ€.λ€μκ³Ό κ°μ΄ μμ νλ κ²μ μ μλ립λλ€: