-
Notifications
You must be signed in to change notification settings - Fork 3
Fix/youl bug fix #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/youl bug fix #150
Changes from 23 commits
6b7ea7c
3257b25
536f3b2
17d4514
59ac630
e0e83ee
0878802
ff82386
f8f4f95
52eb474
013fde3
8ecaabf
fef8165
fea5c28
de86036
4dc9e50
3ce5331
cbb4d4e
2656c9c
43a4179
43fd284
9260be9
96f1e22
0a5ab41
5e014cf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,6 +24,8 @@ export function useCreateCrewQuery() { | |
| } | ||
| queryClient.invalidateQueries({ queryKey: ['crewLists', 'crewDetail'] }); | ||
| toast.success('ν¬λ£¨κ° μμ±λμμ΅λλ€.'); | ||
| localStorage.removeItem('createCrew'); | ||
|
|
||
|
Comment on lines
+27
to
+28
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. π‘ Codebase verification
λμΌν cleanup μμ μ΄ λ κ³³μμ μνλκ³ μμ΄ μ€λ³΅ μ½λκ° μ‘΄μ¬ν©λλ€. ν κ³³μΌλ‘ ν΅ν©νλ κ²μ΄ μ’κ² μ΅λλ€. π Analysis chainCreateCrewPageμμ μ€λ³΅ cleanup μ½λ νμΈμ΄ νμν©λλ€. μ΄μ μμΉμΈ CreateCrewPage μ»΄ν¬λνΈμμ λμΌν cleanup μ½λκ° μμ ν μ κ±°λμλμ§ νμΈμ΄ νμν©λλ€. λ€μ μ€ν¬λ¦½νΈλ‘ νμΈν΄λ³΄μΈμ: π Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# CreateCrewPageμμ localStorage.removeItem('createCrew') μ¬μ© μ¬λΆ νμΈ
rg "localStorage\.removeItem\('createCrew'\)" "src/app/(crew)/crew/create/page.tsx"
Length of output: 91 Script: #!/bin/bash
# Check for any usage of 'createCrew' in localStorage operations within CreateCrewPage
rg "localStorage.*createCrew" "src/app/(crew)/crew/create/page.tsx"
# Also check the entire codebase for any remaining cleanup of 'createCrew' in localStorage
rg "localStorage.*createCrew"
# Use ast-grep to find any useEffect hooks that might contain cleanup
ast-grep --pattern 'useEffect(() => { $$$ }, $$$)' "src/app/(crew)/crew/create/page.tsx"
Length of output: 543 |
||
| router.push(`/crew/detail/${data.crewId}`); | ||
| }, | ||
| onError: (error) => { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π οΈ Refactor suggestion
validateFile ν¨μ νΈμΆ μ΅μ ν νμ
validateFile ν¨μκ° λ λ² νΈμΆλκ³ μμ΄ μ±λ₯μ λΉν¨μ¨μ μ΄λ©°, ν¨μκ° λΆμμ©μ κ°μ§ κ²½μ° μΌκ΄μ± λ¬Έμ κ° λ°μν μ μμ΅λλ€.
λ€μκ³Ό κ°μ΄ μμ νλ κ²μ μ μλ립λλ€: