Skip to content

Feat/135/not found 디자인 수정 #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yulrang merged 7 commits into from
Nov 22, 2024
Merged

Feat/135/not found 디자인 수정 #167

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
207266a
✨ Feat: Not Found 추가
yulrang Nov 19, 2024
f484044
💄 Design: 디자인 개선
yulrang Nov 20, 2024
c329fa2
Merge branch 'develop' into Feat/135/NotFound
yulrang Nov 21, 2024
cb40587
💄 Design: not-found 디자인 수정
yulrang Nov 21, 2024
249c3ae
💄 Design: favicon 추가
yulrang Nov 22, 2024
48b530e
🚨 Fix: 임포트 정리
yulrang Nov 22, 2024
3ea7466
🐛 Fix : 오류처리 추가
yulrang Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added src/app/favicon.ico
View file
Open in desktop
Binary file not shown.
117 changes: 52 additions & 65 deletions src/app/not-found.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,79 +1,66 @@
'use client';

import Link from 'next/link';
import { useMediaQuery } from '@mantine/hooks';
import { theme } from '../styles/theme';
import { useRouter } from 'next/navigation';
import Button from '../components/common/input/button';

export default function NotFound() {
const isMobile = useMediaQuery(`(max-width: ${theme.breakpoints.md})`);
const router = useRouter();

return (
<div className="h-screen md:flex md:items-center md:justify-center">
<div className="flex h-full flex-col items-center justify-center gap-10 md:relative md:h-auto">
<svg
xmlns="http://www.w3.org/2000/svg"
xmlnsXlink="http://www.w3.org/1999/xlink"
width="500"
height="300"
className="w-full"
viewBox="0 0 500 300"
<div className="fixed inset-0 flex w-screen items-center justify-center">
<p className="fixed left-1/2 -translate-x-1/2 text-404-back text-blue-50" aria-hidden="true">
404
</p>
<div className="relative z-10 flex flex-col items-center">
<h1 className="text-404 font-semibold text-blue-500">404</h1>
<p className="text-2xl font-semibold text-gray-900">
&quot;죄송합니다. 페이지를 찾을 수 없습니다. 😢&quot;
</p>
<Button
onClick={() => router.back()}
className="btn-filled mt-20 flex h-11 items-center rounded-xl px-16 text-base font-semibold"
>
<defs>
<path
id="wave"
d="m-115,50q38-30 75,0t75,0 75,0 75,0
75,0 75,0 75,0 75,0 75,0 75,0 75,0 75,0 75,0 75,0 75,0 75,0 75,0 75,0 75,0 75,0 75,0 75,0
v20 h-1540 v-20"
className="translate-y-[110px]"
/>
<clipPath id="wave-clip-front">
<use className="animate-wave" href="#wave" />
<rect x="0" y="0" width="100%" height="180" />
</clipPath>
<clipPath id="wave-clip-middle">
<use className="animate-wave" href="#wave" />
<rect x="0" y="180" width="100%" height="150" />
</clipPath>
<linearGradient id="grad-front" x1="0%" y1="0" x2="100%" y2="100%">
<stop offset="0%" stopColor="#60A5FA" stopOpacity="1" />
<stop offset="100%" stopColor="#3388FF" stopOpacity="1" />
</linearGradient>
<text
id="clipped-wave"
x={isMobile ? '50' : '0'}
y="260"
fontFamily="Helvetica"
fontWeight="bold"
fontSize={isMobile ? '15rem' : '18.75rem'}
>
404
</text>
</defs>
뒤로 가기
</Button>
</div>
Copy link

@coderabbitai coderabbitai bot Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

에러 처리 개선 제안

현재 구현은 잘 되어있지만, 뒤로가기 동작 시 발생할 수 있는 예외 상황(예: 히스토리가 없는 경우)에 대한 처리가 필요할 수 있습니다.

         <Button
-          onClick={() => router.back()}
+          onClick={() => {
+            try {
+              router.back();
+            } catch {
+              router.push('/');
+            }
+          }}
           className="btn-filled mt-20 flex h-11 items-center rounded-xl px-16 text-base font-semibold"
         >
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<div className="relative z-10 flex flex-col items-center">
<h1 className="text-404 font-semibold text-blue-500">404</h1>
<p className="text-2xl font-semibold text-gray-900">
&quot;죄송합니다. 페이지를 찾을 수 없습니다. 😢&quot;
</p>
<Button
onClick={() => router.back()}
className="btn-filled mt-20 flex h-11 items-center rounded-xl px-16 text-base font-semibold"
>
<defs>
<path
id="wave"
d="m-115,50q38-30 75,0t75,0 75,0 75,0
75,0 75,0 75,0 75,0 75,0 75,0 75,0 75,0 75,0 75,0 75,0 75,0 75,0 75,0 75,0 75,0 75,0 75,0
v20 h-1540 v-20"
className="translate-y-[110px]"
/>
<clipPath id="wave-clip-front">
<use className="animate-wave" href="#wave" />
<rect x="0" y="0" width="100%" height="180" />
</clipPath>
<clipPath id="wave-clip-middle">
<use className="animate-wave" href="#wave" />
<rect x="0" y="180" width="100%" height="150" />
</clipPath>
<linearGradient id="grad-front" x1="0%" y1="0" x2="100%" y2="100%">
<stop offset="0%" stopColor="#60A5FA" stopOpacity="1" />
<stop offset="100%" stopColor="#3388FF" stopOpacity="1" />
</linearGradient>
<text
id="clipped-wave"
x={isMobile ? '50' : '0'}
y="260"
fontFamily="Helvetica"
fontWeight="bold"
fontSize={isMobile ? '15rem' : '18.75rem'}
>
404
</text>
</defs>
뒤로 가기
</Button>
</div>
<div className="relative z-10 flex flex-col items-center">
<h1 className="text-404 font-semibold text-blue-500">404</h1>
<p className="text-2xl font-semibold text-gray-900">
&quot;죄송합니다. 페이지를 찾을 수 없습니다. 😢&quot;
</p>
<Button
onClick={() => {
try {
router.back();
} catch {
router.push('/');
}
}}
className="btn-filled mt-20 flex h-11 items-center rounded-xl px-16 text-base font-semibold"
>
뒤로 가기
</Button>
</div>

<svg
className="absolute bottom-0 left-0 h-[20vh] w-screen"
xmlns="http://www.w3.org/2000/svg"
xmlnsXlink="http://www.w3.org/1999/xlink"
viewBox="0 24 150 28"
preserveAspectRatio="none"
shape-rendering="auto"
>
<defs>
<path
id="gentle-wave"
d="M-160 44c30 0 58-18 88-18s 58 18 88 18 58-18 88-18 58 18 88 18 v44h-352z"
/>
</defs>
<g className="parallax">
<use
href="#clipped-wave"
clipPath="url(#wave-clip-middle)"
fill="url(#grad-front)"
fillOpacity="0.88"
className="animate-duration-[7s] animate-delay-[2000ms] animate-wave"
xlinkHref="#gentle-wave"
x="60"
y="0"
fill="#93C5FD"
/>
<use
href="#clipped-wave"
clipPath="url(#wave-clip-front)"
fill="url(#grad-front)"
fillOpacity="0.77"
className="animate-duration-[14s] animate-delay-[4000ms] animate-wave"
xlinkHref="#gentle-wave"
x="48"
y="3"
fill="#BFDBFE"
/>
</svg>
<div className="flex w-full flex-col items-center gap-9 pb-10 md:absolute md:-bottom-10 md:translate-y-full">
<p className="text-2xl font-semibold text-gray-900">
&quot;페이지를 찾을 수 없습니다. 😢&quot;
</p>
<Link
href="/"
className="btn-filled flex h-11 items-center rounded-xl px-16 text-base font-semibold"
>
홈으로 가기
</Link>
</div>
</div>
<use
className="animate-duration-[20s] animate-delay-[6000ms] animate-wave"
xlinkHref="#gentle-wave"
x="0"
y="5"
fill="#DBEAFE"
/>
</g>
</svg>
</div>
);
}
9 changes: 5 additions & 4 deletions tailwind.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ const config: Config = {
base: ['1rem', { lineHeight: '1.5rem' }],
sm: ['0.875rem', { lineHeight: '1.25rem' }],
xs: ['0.75rem', { lineHeight: '1rem' }],
404: ['18.75rem', { lineHeight: '18.75rem' }],
404: ['26.8vh', { lineHeight: '26.8vh' }],
'404-back': ['87.5vh', { lineHeight: '87.5vh' }],
},
fontWeight: {
bold: '700',
Expand Down Expand Up @@ -131,13 +132,13 @@ const config: Config = {
'100%': { opacity: '1' },
},
wave: {
'0%': { transform: 'translate(0)' },
'100%': { transform: 'translate(-30%)' },
'0%': { transform: 'translate(-90px)' },
'100%': { transform: 'translate(85px)' },
},
},
animation: {
fade: 'show 0.5s ease-in',
wave: 'wave 0.8s linear infinite',
wave: 'wave 10s ease infinite',
},
},
},
Expand Down