Skip to content

Fix/youl bug fix : 로고, 파비콘 교체, 헤더 스타일 변경 #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yulrang merged 36 commits into from
Nov 22, 2024
Merged

Fix/youl bug fix : 로고, 파비콘 교체, 헤더 스타일 변경 #171

Show file tree
Hide file tree
Changes from 31 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
6b7ea7c
Feat: 스켈레톤 컴포넌트 추가
yulrang Nov 20, 2024
3257b25
🐛 Fix: 컬럼 수정
yulrang Nov 20, 2024
536f3b2
✨ Feat: 마이페이지 프로필 스켈레톤 추가
yulrang Nov 20, 2024
17d4514
✨ Feat: 작성가능한리뷰 스켈레톤 추가
yulrang Nov 20, 2024
59ac630
✨ Feat: 나의 리뷰 스켈레톤 추가가
yulrang Nov 20, 2024
e0e83ee
♿️ Fix: 접근성 개선
yulrang Nov 20, 2024
0878802
✨ Feat: 나의 약속 로딩 스켈레톤 추가
yulrang Nov 20, 2024
ff82386
💄 Design: 호버시 그림자 적용
yulrang Nov 20, 2024
f8f4f95
🚨 Fix: 빌드 오류 수정
yulrang Nov 20, 2024
52eb474
🐛 Fix: DateTimePicker 동작개선
yulrang Nov 20, 2024
013fde3
♿️ Fix: 크루 폼 접근성 개선
yulrang Nov 20, 2024
8ecaabf
♿️ Fix : 약속 폼 접근성 개선
yulrang Nov 20, 2024
fef8165
♿️ Fix: 크루찾기 접근성 개선
yulrang Nov 20, 2024
fea5c28
🐛 Fix: 이미지 fill, cover 워닝 없애기
yulrang Nov 20, 2024
de86036
Merge branch 'develop' into Fix/YoulBugFix
yulrang Nov 20, 2024
4dc9e50
Merge branch 'develop' into Fix/YoulBugFix
yulrang Nov 20, 2024
3ce5331
🍱 Fix: 샘플 이미지 교체
yulrang Nov 21, 2024
cbb4d4e
✨ Feat: 메타 설정
yulrang Nov 21, 2024
2656c9c
Merge branch 'Fix/YoulBugFix' of https://github.com/CodeitFESI4-Team1…
yulrang Nov 21, 2024
43a4179
Merge branch 'develop' into Fix/YoulBugFix
yulrang Nov 21, 2024
43fd284
⬇️ Chore: package install
yulrang Nov 21, 2024
9260be9
🐛 Fix: 파일인풋 동작 개선
yulrang Nov 21, 2024
96f1e22
Co-authored-by: JEP <juepark42@gmail.com>
yulrang Nov 21, 2024
0a5ab41
🐛 Fix: FileInput 동작 개선
yulrang Nov 21, 2024
5e014cf
🚨 Fix: 빌드오류 수정
yulrang Nov 21, 2024
ec67b02
Merge branch 'develop' into Fix/YoulBugFix
yulrang Nov 22, 2024
0c54b07
🎨 Style: 린트프리티어 적용
yulrang Nov 22, 2024
b4ace51
💄 Design: 헤더 수정
yulrang Nov 22, 2024
71e97a9
🔥 Chore: 파일 정리
yulrang Nov 22, 2024
d154577
🐛 Fix: 헤더 동작 개선
yulrang Nov 22, 2024
c13bc69
🐛 Fix: 크루 찾기 메뉴 원래대로
yulrang Nov 22, 2024
7b9f764
💄 Design: 헤더 디자인 수정
yulrang Nov 22, 2024
8da1ffa
💄 Design: 로그인 폰트사이즈 변경
yulrang Nov 22, 2024
cc04b42
🐛 Fix: 이미지 경로 수정
yulrang Nov 22, 2024
3a534b6
🍱 Chore: 압축된 이미지로 교체
yulrang Nov 22, 2024
7423c4a
🔧 Chore: 파비콘 설정 추가
yulrang Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions public/assets/images/logo-icon.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed public/assets/images/logo.png
View file
Open in desktop
Binary file not shown.
9 changes: 9 additions & 0 deletions public/assets/images/logo.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/app/favicon.ico
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion src/components/common/header/container.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export default function Header() {
const { data: user } = useUser();

return (
<div>
<div className="sticky top-0 z-10">
<HeaderPresenter
isAuth={isAuth}
handleLogout={handleLogout}
Expand Down
17 changes: 9 additions & 8 deletions src/components/common/header/presenter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ import Link from 'next/link';
import { usePathname } from 'next/navigation';
import { Menu } from '@mantine/core';
import { Profile } from '@/src/components/common/profile';
import Logo from '@/public/assets/images/logo.png';
import IcoLogo from '@/public/assets/images/logo-icon.svg';
import Logo from '@/public/assets/images/logo.svg';
Comment on lines +8 to +9
Copy link

@coderabbitai coderabbitai bot Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

파비콘 설정 추가 필요

로고 이미지 파일(logo.svg, logo-icon.svg)은 정상적으로 존재하나, 파비콘 관련 파일과 설정이 누락되어 있습니다. 다음 사항들의 추가가 필요합니다:

  • public 디렉토리에 파비콘 파일 추가 필요
  • HTML 파일에 파비콘 설정 추가 필요
  • manifest.json 설정 추가 필요
🔗 Analysis chain

로고 및 파비콘 에셋 확인 필요

PR 목적에 명시된 로고와 파비콘 교체가 완전히 이루어졌는지 확인이 필요합니다.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# 새로운 로고와 파비콘 파일이 올바른 위치에 존재하는지 확인
fd -t f "logo|favicon" public/assets/

Length of output: 104

Script:

#!/bin/bash
# favicon 관련 파일이 public 루트에 있는지 확인
fd -t f "favicon" public/

# HTML 파일에서 favicon 설정 확인
rg -i "favicon" "*.html"

# manifest.json 파일 검색 및 내용 확인
fd "manifest.json" . -x cat {}

Length of output: 130


export interface HeaderPresenterProps {
isAuth: boolean;
Expand All @@ -26,17 +27,17 @@ export default function HeaderPresenter({
}: HeaderPresenterProps) {
const pathname = usePathname();
return (
<header className="sticky top-0 z-10 h-10 w-full bg-blue-500 px-6 md:h-13">
<header className="h-header w-full bg-blue-500 px-4 md:px-6">
<div className="mx-auto flex h-full w-full max-w-[1200px] items-center justify-between">
<div className="flex space-x-2 md:space-x-5 lg:ml-2 lg:space-x-5">
<Link href="/" className="mt-1">
<Image src={Logo} alt="crew logo" width={83} height={30} className="hidden md:block" />
<Image src={Logo} alt="crew logo" width={53} height={28} className="block md:hidden" />
<div className="flex items-center space-x-3.5 md:space-x-5 lg:ml-2 lg:space-x-5">
<Link href="/" className="it ems-center flex gap-2">
<Image src={IcoLogo} alt="crew logo" aria-hidden width={32} height={32} className="" />
<Image src={Logo} alt="crew logo" width={83} height={24} className="hidden md:block" />
</Link>
<nav className="flex items-center space-x-2 text-base font-semibold md:space-x-6 md:text-lg lg:space-x-6">
<nav className="flex items-center space-x-3 text-base font-semibold md:space-x-6 md:text-lg lg:space-x-6">
<Link
href="/"
className={`${pathname === '/' ? 'text-white' : 'text-blue-300'} ml-4 hidden md:block`}
className={`${pathname === '/' ? 'text-white' : 'text-blue-300'} hidden text-sm font-semibold md:block md:text-lg`}
Copy link

@coderabbitai coderabbitai bot Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

네비게이션 링크 스타일 일관성 개선 필요

네비게이션 링크들의 스타일 적용이 일관적이지 않습니다.

다음과 같은 수정을 제안드립니다:

-className={`${pathname === '/' ? 'text-white' : 'text-blue-300'} hidden text-sm font-semibold md:block md:text-lg`}
+className={`${
+  pathname === '/' ? 'text-white' : 'text-blue-300'
+} ml-4 hidden text-sm font-semibold md:block md:text-lg`}
  1. 다른 링크들과 동일한 ml-4 마진 적용
  2. 조건부 클래스와 고정 클래스를 가독성 있게 분리
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<nav className="flex items-center space-x-3 text-base font-semibold md:space-x-6 md:text-lg lg:space-x-6">
<Link
href="/"
className={`${pathname === '/' ? 'text-white' : 'text-blue-300'} ml-4 hidden md:block`}
className={`${pathname === '/' ? 'text-white' : 'text-blue-300'} hidden text-sm font-semibold md:block md:text-lg`}
<nav className="flex items-center space-x-3 text-base font-semibold md:space-x-6 md:text-lg lg:space-x-6">
<Link
href="/"
className={`${
pathname === '/' ? 'text-white' : 'text-blue-300'
} ml-4 hidden text-sm font-semibold md:block md:text-lg`}

>
크루 찾기
</Link>
Expand Down
26 changes: 0 additions & 26 deletions src/components/common/input/button/floating-btn.stories.tsx
View file
Open in desktop

This file was deleted.

19 changes: 0 additions & 19 deletions src/components/common/input/button/floating-btn.tsx
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion tailwind.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,14 @@ const config: Config = {
},
width: {
7.5: '30px',
12.5: '50px',
12.5: '56px',
18: '72px',
27.5: '110px',
29.5: '118px',
30: '120px',
},
height: {
header: '50px',
7.5: '30px',
12.5: '50px',
13: '52px',
Expand Down