Skip to content

Conversation

@HaeJungg
Copy link
Contributor

@HaeJungg HaeJungg commented Nov 24, 2024

πŸ”– Issue Ticket

#185

✍️ Description

  • μ„œλΉ„μŠ€λͺ… μˆ˜μ •
  • 약속 μ‹œκ°„ μˆ˜μ •

βœ… Checklist

PR

  • Branch Convention 확인

    feat/ 피쳐, fix/ 버그 μˆ˜μ •, refactor/ κ°œμ„ 

  • Base Branch 확인
  • μ μ ˆν•œ Label μ§€μ •
  • Assignee 및 Reviewer μ§€μ •

Test

  • 둜컬 μž‘λ™ 확인

Summary by CodeRabbit

  • μƒˆλ‘œμš΄ κΈ°λŠ₯

    • 둜그인 νŽ˜μ΄μ§€μ™€ 인증 λ ˆμ΄μ•„μ›ƒμ˜ ν™˜μ˜ λ©”μ‹œμ§€κ°€ μ—…λ°μ΄νŠΈλ˜μ—ˆμŠ΅λ‹ˆλ‹€.
    • GatheringCard μ»΄ν¬λ„ŒνŠΈμ˜ λ‚ μ§œ 쑰건이 "였늘"둜 λ³€κ²½λ˜μ—ˆμŠ΅λ‹ˆλ‹€.
  • 버그 μˆ˜μ •

    • GatheringCard의 마감 λ©”μ‹œμ§€ λ‘œμ§μ€ μ—¬μ „νžˆ μ •μƒμ μœΌλ‘œ μž‘λ™ν•©λ‹ˆλ‹€.

@HaeJungg HaeJungg linked an issue Nov 24, 2024 that may be closed by this pull request
2 tasks
@coderabbitai
Copy link

coderabbitai bot commented Nov 24, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

이 λ³€κ²½ 사항은 AuthLayout 및 LoginPage μ»΄ν¬λ„ŒνŠΈμ˜ ν™˜μ˜ λ©”μ‹œμ§€μ™€ μ‚¬μš©μž μ•ˆλ‚΄ 문ꡬ의 ν…μŠ€νŠΈλ₯Ό μˆ˜μ •ν•˜κ³ , GatheringCard μ»΄ν¬λ„ŒνŠΈμ˜ λ‚ μ§œ 확인 λ‘œμ§μ„ μ‘°μ •ν•˜λŠ” λ‚΄μš©μ„ ν¬ν•¨ν•©λ‹ˆλ‹€. ꡬ체적으둜, GatheringCardμ—μ„œλŠ” isWithin24Hours λ³€μˆ˜λ₯Ό μ œκ±°ν•˜κ³  isToday둜 λŒ€μ²΄ν•˜μ—¬, μ΄λ²€νŠΈκ°€ μ˜€λŠ˜μΈμ§€ 여뢀에 따라 UI μš”μ†Œμ˜ λ Œλ”λ§ 쑰건을 λ³€κ²½ν–ˆμŠ΅λ‹ˆλ‹€. μ΄λŸ¬ν•œ μˆ˜μ •μ€ μ „λ°˜μ μΈ κΈ°λŠ₯μ΄λ‚˜ κ΅¬μ‘°μ—λŠ” 영ν–₯을 λ―ΈμΉ˜μ§€ μ•ŠμŠ΅λ‹ˆλ‹€.

Changes

파일 경둜 λ³€κ²½ μš”μ•½
src/app/(auth)/layout.tsx AuthLayout μ»΄ν¬λ„ŒνŠΈμ˜ ν™˜μ˜ λ©”μ‹œμ§€λ₯Ό "크루에 μ˜€μ‹  것을 ν™˜μ˜ν•©λ‹ˆλ‹€ πŸ™Œ"μ—μ„œ "크루크루에 μ˜€μ‹  것을 ν™˜μ˜ν•©λ‹ˆλ‹€ πŸ™Œ"둜 λ³€κ²½.
src/app/(auth)/login/page.tsx LoginPage μ»΄ν¬λ„ŒνŠΈμ˜ μ‚¬μš©μž μ•ˆλ‚΄ 문ꡬλ₯Ό "크루가 μ²˜μŒμ΄μ‹ κ°€μš”?"μ—μ„œ "크루크루가 μ²˜μŒμ΄μ‹ κ°€μš”?"둜 λ³€κ²½.
src/components/common/gathering-card/container.tsx isWithin24Hours λ³€μˆ˜λ₯Ό μ œκ±°ν•˜κ³  isToday둜 λŒ€μ²΄. 데이터 κ°€μ Έμ˜€κΈ° 였λ₯˜ 처리 λ‘œμ§μ€ μœ μ§€λ¨.
src/components/common/gathering-card/presenter.tsx GatheringCardPresenterProps μΈν„°νŽ˜μ΄μŠ€μ—μ„œ isWithin24Hours 속성을 μ œκ±°ν•˜κ³  isToday 속성을 μΆ”κ°€. λ Œλ”λ§ 쑰건 λ³€κ²½.

Possibly related PRs

  • πŸš‘ Hotfix: μ—”λ“œν¬μΈνŠΈ λ³€κ²½Β #86: LoginPage μ»΄ν¬λ„ŒνŠΈμ—μ„œ ν…μŠ€νŠΈ μˆ˜μ •μ΄ μ΄λ£¨μ–΄μ‘ŒμœΌλ©°, μ΄λŠ” AuthLayout μ»΄ν¬λ„ŒνŠΈμ˜ ν…μŠ€νŠΈ μ—…λ°μ΄νŠΈμ™€ μœ μ‚¬ν•©λ‹ˆλ‹€.
  • Hotfix/λ‘œκ·ΈμΈν•˜μ§€ μ•Šμ€ μ‚¬μš©μž 처리 #89: μ‚¬μš©μž 인증 처리 λ³€κ²½ 사항이 ν¬ν•¨λ˜μ–΄ μžˆμ–΄, AuthLayout μ»΄ν¬λ„ŒνŠΈμ˜ μ‚¬μš©μž κ²½ν—˜κ³Ό 관련이 μžˆμ„ 수 μžˆμŠ΅λ‹ˆλ‹€.
  • Feat/92/my gathering page editΒ #100: FavoritePage μ»΄ν¬λ„ŒνŠΈμ˜ UI 쑰정이 ν¬ν•¨λ˜μ–΄ μžˆμ–΄, μ• ν”Œλ¦¬μΌ€μ΄μ…˜ μ „λ°˜μ˜ λ””μžμΈ 일관성에 관련이 μžˆμ„ 수 μžˆμŠ΅λ‹ˆλ‹€.
  • Feat/132/create edit gathering api μ—°κ²°Β #133: λͺ¨μž„ 생성을 μœ„ν•œ μƒˆλ‘œμš΄ ν•¨μˆ˜ μΆ”κ°€κ°€ ν¬ν•¨λ˜μ–΄ μžˆμ–΄, AuthLayout μ»΄ν¬λ„ŒνŠΈμ— 영ν–₯을 쀄 수 μžˆλŠ” μ‚¬μš©μž μƒν˜Έμž‘μš©κ³Ό 관련이 μžˆμ„ 수 μžˆμŠ΅λ‹ˆλ‹€.
  • Feat/131/design gatheringsΒ #136: μ‚¬μš©μž μΈν„°νŽ˜μ΄μŠ€μ— 영ν–₯을 쀄 수 μžˆλŠ” λ””μžμΈ λ³€κ²½ 사항이 ν¬ν•¨λ˜μ–΄ μžˆμŠ΅λ‹ˆλ‹€.
  • Feat/139/gathering card UI - λͺ¨λ‹¬ API μ—°κ²°Β #141: ScheduledGatheringCard μ»΄ν¬λ„ŒνŠΈμ˜ μ—…λ°μ΄νŠΈκ°€ AuthLayout의 ν…μŠ€νŠΈ μ—…λ°μ΄νŠΈμ™€ 관련이 μžˆμ„ 수 μžˆμŠ΅λ‹ˆλ‹€.
  • Feat/153/detail page loadingΒ #155: 상세 νŽ˜μ΄μ§€μ— λ‘œλ”© μŠ€μΌˆλ ˆν†€μ„ λ„μž…ν•˜μ—¬ μ‚¬μš©μž κ²½ν—˜μ„ ν–₯μƒμ‹œν‚€λŠ” λ‚΄μš©μ΄ ν¬ν•¨λ˜μ–΄ μžˆμŠ΅λ‹ˆλ‹€.

Suggested reviewers

  • User850413
  • minkyung5x5

🐰 λ³€ν™”λ₯Ό μΆ•ν•˜ν•˜λ©°,
ν…μŠ€νŠΈκ°€ λ°”λ€Œμ—ˆλ„€, 기쁜 μ†Œμ‹!
크루크루의 ν™˜μ˜, 더 λ”°λœ»ν•˜κ²Œ,
였늘의 λͺ¨μž„, ν•¨κ»˜ μ¦κ²¨μš”!
달라진 λͺ¨μŠ΅, 더 λΉ›λ‚˜λ¦¬λΌ,
λͺ¨λ‘ λͺ¨μ—¬, ν•¨κ»˜ λ›°μ–΄λ³΄μž! πŸŽ‰

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

πŸ”§ eslint (1.23.1)

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/app/(auth)/layout.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't determine the plugin "react-hooks" uniquely.

  • /node_modules/eslint-plugin-react-hooks/index.js (loaded in ".eslintrc.js")
  • /node_modules/eslint-config-next/node_modules/eslint-plugin-react-hooks/index.js (loaded in ".eslintrc.js Β» eslint-config-next/core-web-vitals Β» /node_modules/eslint-config-next/index.js Β» plugin:react-hooks/recommended")

Please remove the "plugins" setting from either config or remove either plugin installation.

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@HaeJungg HaeJungg added the fix label Nov 24, 2024
@github-actions
Copy link

@HaeJungg HaeJungg merged commit 5571c18 into develop Nov 24, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

μ„œλΉ„μŠ€λͺ… μˆ˜μ •, 약속 μ‹œκ°„ μˆ˜μ •

2 participants