-
Notifications
You must be signed in to change notification settings - Fork 3
Hofix/index page : 파일샘플 컴포넌트 수정 #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c912369
Hotfix: env 명칭변경
yulrang 4673821
♻️ Refactor: fetchApi 함수 사용
yulrang ad892a2
💄 Desgin: 스타일 수정
yulrang 23473ec
🐛 Fix: 타입 개선, 에러 처리
yulrang 477eaf3
🐛 Fix: 파일 샘플 컴포넌트 수정
yulrang cf1a241
🚨 Fix: 오류 수정
yulrang daf1c9d
🚨 Fix: 빌드 오류 수정
yulrang 0704cc0
🚨 Fix: 빌드 오류 수정
yulrang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import ImgCrewSample01 from './crew-sample-1.jpg'; | ||
| import ImgCrewSample02 from './crew-sample-2.jpg'; | ||
| import ImgCrewSample03 from './crew-sample-3.jpg'; | ||
|
|
||
| const ImgCrewSamples = [ | ||
| ImgCrewSample01, | ||
| ImgCrewSample02, | ||
| ImgCrewSample03, | ||
| ]; | ||
|
|
||
| export default ImgCrewSamples; |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import ImgGatheringSample01 from './gathering-sample-1.jpg'; | ||
| import ImgGatheringSample02 from './gathering-sample-2.jpg'; | ||
| import ImgGatheringSample03 from './gathering-sample-3.jpg'; | ||
|
|
||
| const ImgGatheringSamples = [ | ||
| ImgGatheringSample01, | ||
| ImgGatheringSample02, | ||
| ImgGatheringSample03, | ||
| ]; | ||
|
|
||
| export default ImgGatheringSamples; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import { fetchApi } from '@/src/utils/api'; | ||
| import { CrewCardInform, CrewCardInformResponse } from '@/src/types/crew-card'; | ||
|
|
||
| export async function getCrewList(page: number, limit: number): Promise<CrewCardInformResponse> { | ||
| try { | ||
| const response = await fetchApi<CrewCardInformResponse>( | ||
| `/crews?_page=${page + 1}&_limit=${limit}`, | ||
| { | ||
| method: 'GET', | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| }, | ||
| }, | ||
| ); | ||
| if (!Array.isArray(response)) { | ||
| throw new Error('서버 응답이 올바른 형식이 아닙니다.'); | ||
| } | ||
| const data = response as CrewCardInform[]; | ||
| const hasNextPage = data.length === limit; | ||
|
|
||
| return { data, hasNextPage }; | ||
| } catch (error) { | ||
| throw new Error('크루 리스트를 불러오는데 실패했습니다.'); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
src/components/common/input/file-input-wrap/file-input/index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
onChange 핸들러의 타입 정의와 구현에 대한 개선이 필요합니다.
현재 구현에서 몇 가지 개선할 점이 있습니다:
다음과 같이 수정하는 것을 제안드립니다:
📝 Committable suggestion