-
Notifications
You must be signed in to change notification settings - Fork 3
Feat/96/form #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feat/96/form #97
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
5cc6746
๐ Fix: ๋๋กญ๋ค์ด ๊ฐ ์ ํ์ ํฌ์ปค์ค ์์ ๋๋๋ก ์์
yulrang f1fe204
๐ Fix: ํ
์คํธ ์์ (์ฝ์ ์ก๊ธฐ > ์ฝ์ ๋ง๋ค๊ธฐ)
yulrang af9fb91
๐ Fix: ํฌ๋ฃจ ์์ฑ์ ๋ํ
์ผ ํ์ด์ง๋ก ์ด๋, ๋ฆฌํฉํ ๋ง
yulrang 80f8554
๐ Fix: ์๋ฌ์ํ์ธ๋ฐ ์๋ก ๊ฐ ์ฑ์ธ ๋ ์๋ฌ ํด์ ํ๊ธฐ, ๋ฆฌํฉํ ๋ง
yulrang 63a8e1c
๐ Fix: ์ ํจ์ฑ ๊ฒ์ฌ ๋ ์ง ์ ํ ์ค๋ฅ ์์
yulrang 9657201
๐ Fix: ์คํฌ๋กค๋ฐ ๋๊ฐ๋ก ๋ณด์ด๋ ๋ฌธ์ ์์
yulrang 43cdfa7
๐จ Fix: ๋ฆฐํธ ์ค๋ฅ ์ ๊ฑฐ
yulrang 0683f5a
๐ Fix: ๋ฒํผ ๋งํฌ๋ก ๊ต์ฒด
yulrang c408058
๐ Fix: isToday ํจ์ ๊ฐ์ , ๋ฐ์ดํฐ ํ๊ตญ์๊ฐ ๊ธฐ์ค์ผ๋ก ๋ณ๊ฒฝ
yulrang f101987
๐ Fix: ํผ ๋์ ๊ฐ์
yulrang 7b68352
๐ Fix: ์ด์ ๋ ์ง ์ ํ ๋ฐฉ์ง, isToday ๋ ์ง ๋น๊ต ์์
yulrang 51cfe2f
๐ Fix: MockData ๋ ์ง ํ์ ์์
yulrang 80d21ef
๐ Fix: ์ด๋ฏธ์ง ํ์ผ ํ์ ์ ํ, ํฌ๊ธฐ ์ ํ
yulrang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๐ ๏ธ Refactor suggestion
์๋ฌ ๋ฉ์์ง ํ์ ๋ฐฉ์์ ์ผ๊ด์ฑ ๊ฐ์ ์ด ํ์ํฉ๋๋ค.
ํ์ฌ ์์น ๊ด๋ จ ํ๋๋ค์ ์๋ฌ ๋ฉ์์ง ํ์ ๋ฐฉ์์ด ์ผ๊ด์ ์ด์ง ์์ต๋๋ค:
mainLocation์ ํ๋จ์ ๋ณ๋๋ก ํ์subLocation์ ๋๋กญ๋ค์ด ๋ด๋ถ์ ํ์๋ค์๊ณผ ๊ฐ์ด ํต์ผ๋ ๋ฐฉ์์ผ๋ก ์์ ํ๋ ๊ฒ์ ์ ์๋๋ฆฝ๋๋ค:
Also applies to: 219-219