[feat] 레이아웃 구현 #18
Merged
[feat] 레이아웃 구현 #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for thejulge1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cozy-ito
reviewed
Apr 24, 2025
ghdtnals
approved these changes
Apr 28, 2025
cozy-ito
approved these changes
Apr 30, 2025
Collaborator
cozy-ito
left a comment
cozy-ito
left a comment
There was a problem hiding this comment.
고생하셨습니다. 👍
src/Router.tsx 라우트 파일에 적용까지 하면 좋을 것 같아요!
export const router = createBrowserRouter([
{
Component: AuthLayout,
children: authRoutes,
},
{
Component: MainLayout,
children: appRoutes,
},
]);아마 레이아웃 적용하면, required props를 전달받지 못해서 에러가 날 텐데요!
아래 리뷰에서처럼 굳이 props로 두지 않아도 될 거라고 생각해요 😅
이후 PR에서 전역 상태 및 여러 비동기 요청에 대한 로직으로 대신 처리하면 될 것 같습니다. 🤔
우선 페이지 작업을 위해서 Approved 먼저 드려요!
Comment on lines
+14
to
+18
| isLoggedIn, | ||
| userNavLabel, | ||
| hasAlarm, | ||
| onLogout, | ||
| onToggleAlarm, |
Collaborator
There was a problem hiding this comment.
해당 props 들은 별도로 받지 않아도 될 것 같아요!
isLoggedIn, userNavLabel은 이후 로그인 후의 전역 상태에서 데이터를 받으면 될 것 같고,
hasAlarm, onToggleAlaam도 추후 알람을 위한 컴포넌트에서 처리,
onLogout도 로그아웃 버튼에서 바로 실행하면 될 것 같아요 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
Closes #6
📝 PR 유형
📝작업 내용