[feat] 버튼 컴포넌트 생성 #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for thejulge1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jeonghwanJay
approved these changes
Apr 24, 2025
src/components/Button.tsx
Outdated
| @@ -0,0 +1,61 @@ | |||
| import React from "react"; | |||
|
|
|||
| type ButtonVariant = "primary" | "white" | "disabled"; | |||
Collaborator
There was a problem hiding this comment.
disabled는 버튼의 상태를 나타내는 속성으로 봐도 좋을 것 같습니다 !
그래서 속성값으로 넣어도 좋을 것 같아요 !
export type ButtonVariant = 'primary' | 'white';
interface ButtonProps extends React.ButtonHTMLAttributes<HTMLButtonElement> {
variant?: ButtonVariant;
textSize?: Record<ButtonTextSize, string>;
fullWidth?: boolean;
disabled?: boolean; // disabled 속성 분리
}
cozy-ito
approved these changes
Apr 24, 2025
src/components/Button.tsx
Outdated
Comment on lines
29
to
37
| if (variant === "primary") { | ||
| variantClass = | ||
| "bg-[#EA3C12] text-white hover:bg-[#ca3f2a] active:bg-[#aa3523]"; | ||
| } else if (variant === "white") { | ||
| variantClass = | ||
| "bg-white text-[#EA3C12] border border-[#EA3C12] hover:bg-[#fff5f3] active:bg-[#ffe5e0]"; | ||
| } else if (variant === "disabled") { | ||
| variantClass = "bg-gray-40 text-white cursor-not-allowed"; | ||
| } |
Collaborator
There was a problem hiding this comment.
variantClass의 조건부 스타일 적용도
textSizeClassMap처럼 별도로 분리하시지 않으신 이유가 있을까요? 🤔
분리하면 반복적인 If 구문을 제거할 수 있을 것 같아요! 😆
Suggested change
| if (variant === "primary") { | |
| variantClass = | |
| "bg-[#EA3C12] text-white hover:bg-[#ca3f2a] active:bg-[#aa3523]"; | |
| } else if (variant === "white") { | |
| variantClass = | |
| "bg-white text-[#EA3C12] border border-[#EA3C12] hover:bg-[#fff5f3] active:bg-[#ffe5e0]"; | |
| } else if (variant === "disabled") { | |
| variantClass = "bg-gray-40 text-white cursor-not-allowed"; | |
| } | |
| const variantClassMap: Record<ButtonVariant, string> = { | |
| primary: "bg-[#EA3C12] text-white hover:bg-[#ca3f2a] active:bg-[#aa3523]", | |
| white: | |
| "bg-white text-[#EA3C12] border border-[#EA3C12] hover:bg-[#fff5f3] active:bg-[#ffe5e0]", | |
| disabled: "bg-gray-400 text-white cursor-not-allowed", | |
| }; |
...
const finalClassName = [
...
variantClassMap[variant]
...
] ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝 PR 유형
📝작업 내용
스크린샷 (선택)
💬리뷰 요구사항(선택)