-
Notifications
You must be signed in to change notification settings - Fork 4
[feat] TextField 컴포넌트 구현 (Input, Textarea 공통 컴포넌트) #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for thejulge1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다👍👍
|
input과 textarea의 통합으로 |
almighty55555
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수민님과 같은 의견입니다! TextField.input, TextField.Textarea로 분리하는 게 좋을 것 같아요
#️⃣연관된 이슈
Closes #14
📝 PR 유형
📝작업 내용
공통 컴포넌트 중 TextField 컴포넌트를 구현합니다.
자세한 설명은
TextFieldWiki 페이지를 참고해주세요.스크린샷 (선택)
💬리뷰 요구사항(선택)
asprops를 통해input태그와textarea태그를 호환되게 사용하려다보니,forwardRef를 추가하는 과정에서 타입 정의 코드가 꽤 복잡해진 것 같습니다 ,아예 분리해서 작성하는게 나을 지 고민입니다 하하 😅