Skip to content

Conversation

@jeonghwanJay
Copy link
Collaborator

#️⃣연관된 이슈

Closes #28

📝 PR 유형

해당하는 유형에 'x'로 체크해주세요.

  • 기능 추가 (Feature)
  • 버그 수정 (Bug Fix)
  • 코드 개선 (Refactoring)
  • 스타일 변경 (UI/UX)
  • 문서 작업 (Documentation)
  • 환경 설정 (Configuration)
  • 기타 (Other)

📝작업 내용

  • Modal 공통 컴포넌트 작업
  • AlertModalLayout, ConfirmModalLayout 파일 분리
  • iconType에 따라 내부 레이아웃 컴포넌트 분기

@jeonghwanJay jeonghwanJay self-assigned this Apr 30, 2025
@jeonghwanJay jeonghwanJay added the Feature (기능 추가) 기능을 추가합니다. label Apr 30, 2025
@github-actions github-actions bot requested review from cozy-ito and ghdtnals April 30, 2025 23:41
@netlify
Copy link

netlify bot commented Apr 30, 2025

Deploy Preview for thejulge1 ready!

Name Link
🔨 Latest commit 4f1deda
🔍 Latest deploy log https://app.netlify.com/sites/thejulge1/deploys/6815e20edd18880008608ec8
😎 Deploy Preview https://deploy-preview-53--thejulge1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jeonghwanJay jeonghwanJay changed the title feat: 모달 공통 컴포넌트 분리 및 레이아웃 구조화 [feat] 모달 공통 컴포넌트 분리 및 레이아웃 구조화 May 1, 2025
Copy link
Collaborator

@ghdtnals ghdtnals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!👍

Copy link
Collaborator

@cozy-ito cozy-ito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modal 컴포넌트의 전역 상태화를 한번 고민해봐주세요 🤔
적용하지 않아도 판단 되신다면 지금으로도 괜찮을 것 같아요! 😄

@jeonghwanJay jeonghwanJay requested a review from cozy-ito May 2, 2025 14:53
@jeonghwanJay jeonghwanJay requested a review from cozy-ito May 3, 2025 05:59
@jeonghwanJay jeonghwanJay merged commit 4682123 into dev May 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature (기능 추가) 기능을 추가합니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

공통 컴포넌트 구현 (Modal)

4 participants