-
Notifications
You must be signed in to change notification settings - Fork 4
[feat] 공고 상세 페이지 (사장님) 구현 #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for thejulge1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
almighty55555
approved these changes
May 4, 2025
Collaborator
almighty55555
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
엄청나게 많은 파일이 변화됐네요 ㅎㅎ 고생하셨습니다!!
ghdtnals
approved these changes
May 4, 2025
Collaborator
ghdtnals
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고히셨습니다!👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
Closes #70
📝 PR 유형
📝작업 내용
컴포넌트 관련
NoticeEmployerPage컴포넌트 UI 구현NoticeDetailInfo컴포넌트 (+ 사장님 버전까지 확장)ShopInfoPostCardSkeleton->NoticeDetailSkeleton컴포넌트명 변경그 외 변경 사항
/notice/edit->/notice/edit/:noticeId로 변경NOTICE관련 로직src/apis/loaders/notice.ts파일로 분리src/utils/localStorage.ts유틸 함수 구현 (getLocalStorageValue,setLocalStorageValue)useUpdateRecentNotices. 로컬 스토리지 사용)기타
zustand스토어는 컴포넌트 외부에서도 접근이 가능하네요!? (신기)(컴포넌트 내에서 사용하는 것 같이 상태가 변경되어도 자동으로 반응하지는 않는대요 🤔)
코드 리뷰 후 변경사항
APPLICATION_STATUS상수화NoticeDetailInfoCard컴포넌트 버튼 분리 (NoticeEmployerActionButton,NoticeEmployeeActionButton)useShopApplications커스텀 훅 의존성 배열 요소 추가스크린샷 (선택)
💬리뷰 요구사항(선택)