Refactor ProjectCard class to function component#991
Merged
talyssonoc merged 3 commits intomasterfrom May 9, 2025
Merged
Conversation
julialbq
changed the title
marcelobalexandre
approved these changes
Feb 28, 2025
talyssonoc
reviewed
Feb 28, 2025
| return textArea.value; | ||
| }; | ||
|
|
||
| const renderTag = () => { |
Member
There was a problem hiding this comment.
Instead of creating an inline function, what do you think about creating a separate component just for that? We can keep it in this file, as long as it's not inside the ProjectCard component. It can be in the bottom of the file.
|
|
||
| panelHeading() { | ||
| const { project, joined } = this.props; | ||
| const projectName = () => decodeHTML(project.get('name')); |
Member
There was a problem hiding this comment.
I think we can look if there's a better option to do that instead of using createElement as well.
| const { project, joined } = this.props; | ||
| }; | ||
|
|
||
| const panelBody = () => { |
Member
There was a problem hiding this comment.
We might be able to create a separate component for that as well.
| const { project, joined } = this.props; | ||
| }; | ||
|
|
||
| const renderUsersAvatar = () => { |
Member
There was a problem hiding this comment.
We might be able to create a separate component for that as well.
julialbq
force-pushed
the
refactor/projectcard-class-to-function
branch
from
3e2f195 to
cc6db62
Compare
… reviewer suggestion
vitorfrs-dev
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR do ?
Updates ProjectCard class into a function component.
Related Issues
Update React classes to function components
Screenshots (if applicable)
Additional Notes (if any)