Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modcharting features (using FunkinModchart) #526

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

TheoDevelops
Copy link
Contributor

This pull request adds modcharting features using FunkinModchart.
Modcharting features can be removed by removing the "MODCHARTING_FEATURES" define from Project.xml.

@Tsaku53
Copy link

Tsaku53 commented Jan 8, 2025

We need it !

@NexIsDumb
Copy link
Member

NexIsDumb commented Jan 8, 2025

sorry to say but this unfortunately doesn't work currently as Codename uses Haxe 4.2.5, even though we've been planning to update soon, as for now this cannot work

i wont close this PR though just yet

@NexIsDumb NexIsDumb marked this pull request as draft January 8, 2025 20:20
@TheoDevelops
Copy link
Contributor Author

sorry to say but this unfortunately doesn't work currently as Codename uses Haxe 4.2.5, even though we've been planning to update soon, as for now this cannot work

i wont close this PR though just yet

i just updated funkin-modchart and i removed the haxe 4.3 operators, can u check it again?

@TheoDevelops
Copy link
Contributor Author

TheoDevelops commented Jan 9, 2025

sorry to say but this unfortunately doesn't work currently as Codename uses Haxe 4.2.5, even though we've been planning to update soon, as for now this cannot work

i wont close this PR though just yet

i just updated funkin-modchart and i removed the haxe 4.3 operators, can u check it again?

nvm this still has errors with haxe 4.2, i will be working on it

@TheoDevelops
Copy link
Contributor Author

Update

With v1.1.0 update, the lib now works with haxe 4.2 :D

@TechnikTil
Copy link
Contributor

I'll go do that asap (sorry I'm late)

@TechnikTil
Copy link
Contributor

gotta probably do that tmrw

@TheoDevelops TheoDevelops marked this pull request as ready for review January 13, 2025 12:39
Copy link
Contributor

@TechnikTil TechnikTil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this! Just please add some documentation of some sorts, took me like an hour to figure out how it works. (It would also be good for the codename wiki)

@TheoDevelops
Copy link
Contributor Author

TheoDevelops commented Jan 14, 2025

I love this! Just please add some documentation of some sorts, took me like an hour to figure out how it works. (It would also be good for the codename wiki)

There is documentation, it is on the FunkinModchart readme, although I can also add it to the cne wiki if you like.

@TechnikTil
Copy link
Contributor

I love this! Just please add some documentation of some sorts, took me like an hour to figure out how it works. (It would also be good for the codename wiki)

There is documentation, it is on the FunkinModchart readme, although I can also add it to the cne wiki if you like.

oh there is??? shit there goes an hour wasted
nah you good, maybe link it when this is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants