-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add modcharting features (using FunkinModchart) #526
base: main
Are you sure you want to change the base?
Conversation
We need it ! |
sorry to say but this unfortunately doesn't work currently as Codename uses Haxe 4.2.5, even though we've been planning to update soon, as for now this cannot work i wont close this PR though just yet |
i just updated funkin-modchart and i removed the haxe 4.3 operators, can u check it again? |
nvm this still has errors with haxe 4.2, i will be working on it |
UpdateWith v1.1.0 update, the lib now works with haxe 4.2 :D |
I'll go do that asap (sorry I'm late) |
gotta probably do that tmrw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this! Just please add some documentation of some sorts, took me like an hour to figure out how it works. (It would also be good for the codename wiki)
There is documentation, it is on the FunkinModchart readme, although I can also add it to the cne wiki if you like. |
oh there is??? shit there goes an hour wasted |
This pull request adds modcharting features using FunkinModchart.
Modcharting features can be removed by removing the "MODCHARTING_FEATURES" define from Project.xml.