Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Add recursive convert function #1

Merged
merged 13 commits into from
Feb 14, 2024
Merged

[FEAT] Add recursive convert function #1

merged 13 commits into from
Feb 14, 2024

Conversation

KaiSaba
Copy link
Collaborator

@KaiSaba KaiSaba commented Feb 8, 2024 •
edited
Loading

  • Update constant name and function parameters name.
  • Add function to convert LocalizedJSONSchema to JSONSchema6

@KaiSaba KaiSaba requested review from CGNonofr and JeanDamien and removed request for CGNonofr and JeanDamien February 8, 2024 17:14
@KaiSaba
Copy link
Collaborator Author

KaiSaba commented Feb 8, 2024

@CGNonofr I updated the function renderJsonSchema:

@CGNonofr CGNonofr requested review from SimonFuetCG and CGNonofr and removed request for CGNonofr and SimonFuetCG February 8, 2024 17:23
CGNonofr
CGNonofr reviewed Feb 12, 2024
View reviewed changes
src/description.ts Outdated Show resolved Hide resolved
src/description.ts Outdated Show resolved Hide resolved
src/description.ts Outdated Show resolved Hide resolved
@SimonFuetCG SimonFuetCG requested a review from CGNonofr February 13, 2024 17:09
CGNonofr
CGNonofr reviewed Feb 14, 2024
View reviewed changes
src/description.ts Outdated Show resolved Hide resolved
@CGNonofr CGNonofr self-requested a review February 14, 2024 11:10
CGNonofr
CGNonofr requested changes Feb 14, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@CGNonofr CGNonofr self-requested a review February 14, 2024 13:34
@KaiSaba KaiSaba merged commit 736e557 into main Feb 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CGNonofr CGNonofr CGNonofr approved these changes

@JeanDamien JeanDamien Awaiting requested review from JeanDamien

@SimonFuetCG SimonFuetCG Awaiting requested review from SimonFuetCG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KaiSaba @CGNonofr