Skip to content

Commit

Permalink
fix: remove useless service override
Browse files Browse the repository at this point in the history
the title service override does override the window title
  • Loading branch information
Loïc Mangeonjean committed Feb 13, 2024
1 parent abbf0e5 commit 4441384
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 30 deletions.
42 changes: 18 additions & 24 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,7 @@
"@codingame/monaco-vscode-timeline-service-override": "^2.1.4",
"@codingame/monaco-vscode-typescript-basics-default-extension": "^2.1.3",
"@codingame/monaco-vscode-vb-default-extension": "^2.1.3",
"@codingame/monaco-vscode-view-banner-service-override": "^2.1.4",
"@codingame/monaco-vscode-view-status-bar-service-override": "^2.1.3",
"@codingame/monaco-vscode-view-title-bar-service-override": "^2.1.4",
"@codingame/monaco-vscode-views-service-override": "^2.1.3",
"@codingame/monaco-vscode-working-copy-service-override": "^2.1.3",
"@codingame/monaco-vscode-xml-default-extension": "^2.1.3",
Expand Down
4 changes: 0 additions & 4 deletions src/features/views.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import getViewsServiceOverride from '@codingame/monaco-vscode-views-service-override'
import getStatusBarServiceOverride from '@codingame/monaco-vscode-view-status-bar-service-override'
import getTitleBarServiceOverride from '@codingame/monaco-vscode-view-title-bar-service-override'
import getQuickAccessServiceOverride from '@codingame/monaco-vscode-quickaccess-service-override'
import getBannerServiceOverride from '@codingame/monaco-vscode-view-banner-service-override'
import { editorOpenHandlerRegistry, registerServices, useGlobalPicker } from '../services'

import '@codingame/monaco-vscode-theme-seti-default-extension'
Expand All @@ -16,8 +14,6 @@ registerServices({
return editorOpenHandlerRegistry.openCodeEditor(model, input, sideBySide)
}),
...getStatusBarServiceOverride(),
...getTitleBarServiceOverride(),
...getBannerServiceOverride(),
...getQuickAccessServiceOverride({
shouldUseGlobalPicker () {
return useGlobalPicker()
Expand Down

0 comments on commit 4441384

Please sign in to comment.