-
Notifications
You must be signed in to change notification settings - Fork 40
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #581 from CodinGame/fix-extension-host-worker-cdn
Fix extension host worker when used with a cdn
- Loading branch information
Showing
2 changed files
with
35 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 | ||
From: =?UTF-8?q?Lo=C3=AFc=20Mangeonjean?= <[email protected]> | ||
Date: Tue, 11 Feb 2025 19:59:40 +0100 | ||
Subject: [PATCH] fix: always set parent origin | ||
|
||
--- | ||
.../services/extensions/browser/webWorkerExtensionHost.ts | 2 +- | ||
1 file changed, 1 insertion(+), 1 deletion(-) | ||
|
||
diff --git a/src/vs/workbench/services/extensions/browser/webWorkerExtensionHost.ts b/src/vs/workbench/services/extensions/browser/webWorkerExtensionHost.ts | ||
index eade34150d1..95106926e93 100644 | ||
--- a/src/vs/workbench/services/extensions/browser/webWorkerExtensionHost.ts | ||
+++ b/src/vs/workbench/services/extensions/browser/webWorkerExtensionHost.ts | ||
@@ -85,6 +85,7 @@ export class WebWorkerExtensionHost extends Disposable implements IExtensionHost | ||
suffixSearchParams.set('debugged', '1'); | ||
} | ||
COI.addSearchParam(suffixSearchParams, true, true); | ||
+ suffixSearchParams.set('parentOrigin', mainWindow.origin); | ||
|
||
const suffix = `?${suffixSearchParams.toString()}`; | ||
|
||
@@ -110,7 +111,6 @@ export class WebWorkerExtensionHost extends Disposable implements IExtensionHost | ||
); | ||
|
||
const res = new URL(`${baseUrl}/out/${iframeModulePath}${suffix}`); | ||
- res.searchParams.set('parentOrigin', mainWindow.origin); | ||
res.searchParams.set('salt', stableOriginUUID); | ||
return res.toString(); | ||
} |
4d042d7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Published on https://monaco-vscode-api.netlify.app as production
🚀 Deployed on https://67abba4abf6008ecc9a12ee0--monaco-vscode-api.netlify.app