Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/edit mentor details#696 #708

Merged
merged 18 commits into from
May 10, 2020
Merged

Feature/edit mentor details#696 #708

merged 18 commits into from
May 10, 2020

Conversation

pandaa880
Copy link
Contributor

@pandaa880 pandaa880 commented May 4, 2020 •
edited by moshfeu
Loading

resolve #696

@pandaa880 pandaa880 closed this May 4, 2020
@pandaa880 pandaa880 reopened this May 4, 2020
moshfeu
moshfeu requested changes May 4, 2020
View reviewed changes
Copy link
Member

@moshfeu moshfeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great job!
Please review my comments.

src/Me/Modals/EditMentorDetails.js Outdated Show resolved Hide resolved
src/Me/Modals/EditMentorDetails.js Outdated Show resolved Hide resolved
src/Me/Modals/model.js Outdated Show resolved Hide resolved
src/Me/components/Checkbox/Checkbox.js Outdated Show resolved Hide resolved
moshfeu
moshfeu reviewed May 4, 2020
View reviewed changes
src/Me/Modals/EditMentorDetails.js Outdated Show resolved Hide resolved
src/Me/Modals/EditMentorDetails.js Outdated Show resolved Hide resolved
@moshfeu
Copy link
Member

moshfeu commented May 5, 2020

Another thing. After saving, the changes should be reflected in the UI.
For example, if I change my name, the name should be changed in the details section too.

Screen Shot 2020-05-05 at 9 03 20

pandaa880 added 6 commits May 5, 2020 21:43
@pandaa880
change checkbox attribute to defaultChecked to avoid uncontrolled to …
0dd14af 
…controlled warning
@pandaa880
change to useModal hook
b819d51
@pandaa880
remove unnecessary code
2fa19bc
@pandaa880
update with review comments changes
029f09e 
  replace CustomFormField with ExtendedFormField. remove avatar field
  from the mentorDetails. fix styling for fields with innerfields.
  change updateMentor fucntion params.
@pandaa880
add color for label
c0e3f71
@pandaa880
add prop to close modal
c6783cc
@pandaa880
Copy link
Contributor Author

Another thing. After saving, the changes should be reflected in the UI.
For example, if I change my name, the name should be changed in the details section too.

Screen Shot 2020-05-05 at 9 03 20

after saving, Modal should be closed upon successful response ? or user will manually close it ?

@moshfeu
Copy link
Member

moshfeu commented May 6, 2020

Should be closed

moshfeu
moshfeu approved these changes May 10, 2020
View reviewed changes
Copy link
Member

@moshfeu moshfeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!
Thank you

@moshfeu moshfeu merged commit 8a94bab into Coding-Coach:master May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moshfeu moshfeu moshfeu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<EditMentorDetails /> component
2 participants
@pandaa880 @moshfeu