Skip to content

Conversation

@utilForever
Copy link
Member

This revision includes:

@utilForever utilForever linked an issue Jul 20, 2025 that may be closed by this pull request
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors unit tests to use the rstest crate for parameterized testing instead of individual test functions with repetitive assertions. The change improves test maintainability by consolidating multiple similar test cases into single parameterized test functions.

  • Replaced four individual test functions with four parameterized test functions using rstest
  • Added rstest dependency to enable parameterized testing functionality

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/file_manager/models.rs Refactored unit tests from individual functions to parameterized tests using rstest
Cargo.toml Added rstest crate as a dev dependency
Comments suppressed due to low confidence (2)

src/file_manager/models.rs:99

  • [nitpick] The function name 'fail_to_parse_language_from_invalid_filename' is inconsistent with the original 'fails_to_parse_language_from_invalid_filename'. Consider using 'fails_to_parse_language_from_invalid_filename' to maintain consistency with the original naming convention.
    fn fail_to_parse_language_from_invalid_filename(

src/file_manager/models.rs:126

  • [nitpick] The function name 'fail_to_parse_language_from_invalid_extension' is inconsistent with the original 'fails_to_parse_language_from_invalid_extension'. Consider using 'fails_to_parse_language_from_invalid_extension' to maintain consistency with the original naming convention.
    fn fail_to_parse_language_from_invalid_extension(

@utilForever utilForever marked this pull request as ready for review July 20, 2025 12:14
Copy link
Member

@w8385 w8385 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구조화돼서 훨씬 깔끔하네요

@utilForever utilForever merged commit 785fcf9 into main Jul 20, 2025
4 checks passed
@utilForever utilForever deleted the 43-replace-with-rstest branch July 20, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

일부 유닛 테스트를 rstest로 대체

4 participants