31 change UI #33
Open
31 change UI #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
4 tasks
tmdghks
requested changes
Jun 30, 2025
| title: 'Bibimbap', | ||
| description: 'A delicious Korean dish', | ||
| title: 'coduck', | ||
| description: 'coduck~', |
There was a problem hiding this comment.
이 부분은 아직 placeholder로 두고 나중에 수정 되는 부분인 거죠?
There was a problem hiding this comment.
그렇습니다 이름 바꾸고 적절한 수정이 프론트딴에선 안들어가서 일단 임시 확인차..
적절한 멘트 (누군가가) 수정해야할 듯 합니다
지금보니 이 브랜치에서 할 내용은 아니었던듯 싶네요
There was a problem hiding this comment.
우선은 coduck으로 남겨둬도 괜찮을 것 같긴 해요
다만 package.json에서는 아직 bibimbap-frontend라고 되어 있어서 아직 불일치가 존재하는 것 같아요. README.md, LICENSE에서도 비슷한 이슈가 존재하고 있어요
{
"name": "bibimbap-frontend",
"version": "0.1.0",
"private": true,
tmdghks
reviewed
Sep 23, 2025
Comment on lines
+42
to
+46
| <div className='min-h-screen bg-gradient-to-br from-gray-50 to-gray-100'> | ||
| <div className='container px-4 py-6 mx-auto'> | ||
| <div className='flex items-center justify-between mb-6'> | ||
| <div> | ||
| <h1 className='text-3xl font-bold text-gray-900 flex items-center gap-3'> |
There was a problem hiding this comment.
src/app/problems/page.tsx의 41번 라인부터 45번 라인까지 똑같은 css 코드가 있어서, 이런 부분은 나중에 찾아서 공통으로 묶어서 리팩토링 하면 좋을 것 같아요
/* globals.css */
.page-background {
@apply min-h-screen bg-gradient-to-br from-gray-50 to-gray-100
}
.page-container {
@apply container px-4 py-6 mx-auto;
}
.page-header {
@apply flex items-center justify-between mb-6;
}
.page-title {
@apply text-3xl font-bold text-gray-900 flex items-center gap-3;
}
.page-title-icon {
@apply h-8 w-8 text-primary;
}
| title: 'Bibimbap', | ||
| description: 'A delicious Korean dish', | ||
| title: 'coduck', | ||
| description: 'coduck~', |
There was a problem hiding this comment.
우선은 coduck으로 남겨둬도 괜찮을 것 같긴 해요
다만 package.json에서는 아직 bibimbap-frontend라고 되어 있어서 아직 불일치가 존재하는 것 같아요. README.md, LICENSE에서도 비슷한 이슈가 존재하고 있어요
{
"name": "bibimbap-frontend",
"version": "0.1.0",
"private": true,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
비빔밥 -> 코덕 이름 변화 후 전반적인 대표색, 로고, 메인 페이지 및 관련 css, 이에 따른 하위 페이지 변경 작업에 따른 코드입니다.
구체적인 변경 사항은 다음과 같습니다.
관련 작업을 위한 ui 파일 추가 입니다.