fixed: user delete performance

classes/ColdTrick/EntityViewCounter/Delete.php

@@ -17,7 +17,7 @@ class Delete {
 	 *
 	 * @return void
 	 */
-	public static function deleteViews(\Elgg\Event $event) {
+	public static function deleteViews(\Elgg\Event $event): void {
 		$entity = $event->getObject();
 		if (!$entity instanceof \ElggEntity) {
 			return;
@@ -30,4 +30,25 @@ public static function deleteViews(\Elgg\Event $event) {
 
 		elgg()->db->deleteData($delete);
 	}
+
+	/**
+	 * On delete of a user remove all view annotations in bulk
+	 *
+	 * @param \Elgg\Event $event 'delete', 'user'
+	 *
+	 * @return void
+	 */
+	public static function deleteUserViews(\Elgg\Event $event): void {
+		$entity = $event->getObject();
+		if (!$entity instanceof \ElggUser) {
+			return;
+		}
+
+		// Do a bulk delete to save on performance (eg. not for every annotation a delete sequence)
+		$delete = DBDelete::fromTable(AnnotationsTable::TABLE_NAME);
+		$delete->where($delete->compare('owner_guid', '=', $entity->guid, ELGG_VALUE_GUID))
+			->andWhere($delete->compare('name', '=', ENTITY_VIEW_COUNTER_ANNOTATION_NAME, ELGG_VALUE_STRING));
+
+		elgg()->db->deleteData($delete);
+	}
 }

elgg-plugin.php

@@ -23,6 +23,9 @@
 			'object' => [
 				'\ColdTrick\EntityViewCounter\Delete::deleteViews' => [],
 			],
+			'user' => [
+				'\ColdTrick\EntityViewCounter\Delete::deleteUserViews' => [],
+			],
 		],
 		'permissions_check:annotate:view_counter' => [
 			'all' => [