Complete workspace split refactoring by Coldaine · Pull Request #7 · Coldaine/ColdVox

Coldaine · 2025-09-01T19:01:32Z

Summary

Completes the workspace split architecture with proper module re-exports
Fixes all import paths and test compilation issues
Ensures all 112 tests pass across the workspace

Changes

Architecture Improvements

✅ Added re-export modules (mod.rs) for vad, telemetry, and foundation in app crate
✅ Mapped app-level features to subcrate features properly
✅ Fixed module visibility and import paths throughout codebase

VAD Integration

Connected Level3 and Silero engines through proper feature flags
Updated VadProcessor to consume coldvox_audio::AudioFrame
Fixed frame type conversions (f32 samples with Instant timestamps)

Test Fixes

Fixed vad_pipeline_tests to use new AudioFrame structure
Updated chunker_timing_tests timestamp calculations
Corrected test_transcription_config_default expectations
Fixed NoOp injector metrics recording
Cleaned up all unused imports

Build Fixes

Added missing parking_lot dependency to app crate
Fixed feature flag guards in main.rs (compile-time vs runtime)
Resolved all type inference issues

Test Plan

All workspace tests pass: cargo test --workspace --lib
Examples compile: cargo check --examples
Release build with vosk: cargo build --release --features vosk
VAD pipeline test with Level3: cargo test -p coldvox-app --test vad_pipeline_tests --features level3

Impact

This refactoring provides better separation of concerns and makes the codebase more maintainable by clearly defining module boundaries and dependencies.

🤖 Generated with Claude Code

…n + implementation overview)

…y to reduce confusion

Major refactoring to complete the workspace split architecture: Core Changes: - Add re-export modules in app crate for vad, telemetry, and foundation - Fix all import paths across tests and examples to use new structure - Map app-level features to subcrate features in Cargo.toml - Add missing parking_lot dependency to app crate VAD Integration: - Create vad module re-exporting UnifiedVadConfig, VadMode, constants - Wire up Level3 and Silero engines through feature flags - Update VadProcessor to consume coldvox_audio::AudioFrame - Fix frame type conversions (f32 samples with Instant timestamps) Audio Module: - Re-export AudioChunker, ChunkerConfig, ResamplerQuality, FrameReader - Re-export AudioRingBuffer, AudioProducer, CaptureStats, AudioFrame - Disambiguate AudioFrame types in chunker tests Text Injection: - Add public get_method_priority() wrapper for tests - Fix NoOp injector to properly record metrics - Update processor tests with confidence fields - Fix feature flag guards in main.rs Test Fixes: - Update vad_pipeline_tests to new AudioFrame structure - Fix chunker_timing_tests timestamp calculations - Correct test_transcription_config_default expectations - Remove invalid text-injection feature flag in tests - Clean up all unused imports via cargo fix All tests pass (112 total), examples compile, and release builds successfully. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

Copilot

Pull Request Overview

This PR completes the workspace split refactoring for ColdVox, transforming it from a monolithic crate into a well-organized workspace with specialized subcrates. The purpose is to improve modularity, reduce compilation times, and better isolate optional dependencies.

Key changes include:

Complete workspace architecture with proper module re-exports and feature mapping
Fixed all import paths and compilation issues across 112 tests
Added comprehensive linter remediation documentation and migration guides

Reviewed Changes

Copilot reviewed 128 out of 142 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
linter_remediation_plan.md	Documents fixes for the first 10 linter errors from incorrect crate imports
linter/remediation_plan_*.md	Batch remediation plans for different categories of linter warnings
examples/vosk_test.rs*	Feature-gated Vosk example with fallback when feature disabled
examples/vad_demo.rs	Updated imports to use new workspace structure
docs/*.md	Updated documentation to reflect new crate organization and architecture
docs/tasks/*.md	Comprehensive task planning and implementation guides for workspace features
docs/MIGRATION_GUIDE.md	User migration guide from monolithic to workspace structure

Copilot · 2025-09-01T19:03:06Z

linter_remediation_plan.md

+    -   **Line:** `use crate::vad::config::{UnifiedVadConfig, VadMode};
+    -   **Fix:** `use coldvox_vad::config::{UnifiedVadConfig, VadMode};


Missing closing quote mark on line 22. The line should end with a closing quote mark to match the opening quote.

Suggested change

- **Line:** `use crate::vad::config::{UnifiedVadConfig, VadMode};

- **Fix:** `use coldvox_vad::config::{UnifiedVadConfig, VadMode};

- **Line:** `use crate::vad::config::{UnifiedVadConfig, VadMode};`

- **Fix:** `use coldvox_vad::config::{UnifiedVadConfig, VadMode};`

Copilot · 2025-09-01T19:03:06Z

linter_remediation_plan.md

+    -   **Line:** `use crate::foundation::error::AudioConfig;
+    -   **Fix:** `use coldvox_foundation::error::AudioConfig;


Missing closing quote mark on line 26. The line should end with a closing quote mark to match the opening quote.

Suggested change

- **Line:** `use crate::foundation::error::AudioConfig;

- **Fix:** `use coldvox_foundation::error::AudioConfig;

- **Line:** `use crate::foundation::error::AudioConfig;`

- **Fix:** `use coldvox_foundation::error::AudioConfig;`

Copilot · 2025-09-01T19:03:06Z

linter_remediation_plan.md

+5.  **Error:** `unresolved import 
+`crate::audio::capture
+`
+    -   **Line:** `use crate::audio::capture::AudioCaptureThread;


Missing closing quote mark on line 32. The line should end with a closing quote mark to match the opening quote.

Suggested change

- **Line:** `use crate::audio::capture::AudioCaptureThread;

- **Line:** `use crate::audio::capture::AudioCaptureThread;`

Copilot · 2025-09-01T19:03:07Z

linter_remediation_plan.md

+    -   **Line:** `use crate::audio::chunker::{AudioChunker, ChunkerConfig};
+    -   **Fix:** `use coldvox_audio::chunker::{AudioChunker, ChunkerConfig};


Missing closing quote mark on line 38. The line should end with a closing quote mark to match the opening quote.

Suggested change

- **Line:** `use crate::audio::chunker::{AudioChunker, ChunkerConfig};

- **Fix:** `use coldvox_audio::chunker::{AudioChunker, ChunkerConfig};

- **Fix:** `use coldvox_audio::chunker::{AudioChunker, ChunkerConfig};`

Copilot · 2025-09-01T19:03:07Z

linter_remediation_plan.md

+    -   **Line:** `use crate::audio::frame_reader::FrameReader;
+    -   **Fix:** `use coldvox_audio::frame_reader::FrameReader;


Missing closing quote mark on line 44. The line should end with a closing quote mark to match the opening quote.

Suggested change

- **Line:** `use crate::audio::frame_reader::FrameReader;

- **Fix:** `use coldvox_audio::frame_reader::FrameReader;

- **Line:** `use crate::audio::frame_reader::FrameReader;`

- **Fix:** `use coldvox_audio::frame_reader::FrameReader;`

Copilot · 2025-09-01T19:03:07Z

linter_remediation_plan.md

+### File: `crates/app/src/hotkey/listener.rs`
+
+10. **Error:** `failed to resolve: could not find 'vad' in the crate root`
+    -   **Line:** `use crate::vad::types::VadEvent;


Missing closing quote mark on line 62. The line should end with a closing quote mark to match the opening quote.

Suggested change

- **Line:** `use crate::vad::types::VadEvent;

- **Line:** `use crate::vad::types::VadEvent;`

Copilot · 2025-09-01T19:03:08Z

linter/remediation_plan_2.md

+### File: `crates/app/src/probes/vad_mic.rs`
+
+1.  **Error:** `unresolved import `crate::audio::ring_buffer``
+    -   **Line:** `use crate::audio::ring_buffer::AudioRingBuffer;


Missing closing quote mark on line 10. The line should end with a closing quote mark to match the opening quote.

Suggested change

- **Line:** `use crate::audio::ring_buffer::AudioRingBuffer;

- **Line:** `use crate::audio::ring_buffer::AudioRingBuffer;`

Copilot · 2025-09-01T19:03:08Z

linter/remediation_plan_2.md

+`    -   **Fix:** `use coldvox_audio::ring_buffer::AudioRingBuffer;
+`
+2.  **Error:** `could not find `chunker` in `audio``
+    -   **Line:** `resampler_quality: crate::audio::chunker::ResamplerQuality::Balanced,


Missing closing quote mark on line 14. The line should end with a closing quote mark to match the opening quote.

Suggested change

- **Line:** `resampler_quality: crate::audio::chunker::ResamplerQuality::Balanced,

- **Line:** `resampler_quality: crate::audio::chunker::ResamplerQuality::Balanced,`

Copilot · 2025-09-01T19:03:08Z

linter/remediation_plan_2.md

+### File: `crates/app/src/audio/vad_adapter.rs`
+
+3.  **Error:** `use of undeclared type `Level3Vad``
+    -   **Line:** `Box::new(Level3Vad::new(level3_config))


Missing closing quote mark on line 21. The line should end with a closing quote mark to match the opening quote.

Suggested change

- **Line:** `Box::new(Level3Vad::new(level3_config))

- **Line:** `Box::new(Level3Vad::new(level3_config))`

Copilot · 2025-09-01T19:03:08Z

linter/remediation_plan_2.md

+    -   **Fix:** Change the import from `use coldvox_vad::Level3Vad;` to `use coldvox_vad::level3::Level3Vad;`.
+
+4.  **Error:** `mismatched types`
+    -   **Line:** `Box::new(SileroEngine::new(config.silero.clone())?)


Missing closing quote mark on line 26. The line should end with a closing quote mark to match the opening quote.

Suggested change

- **Line:** `Box::new(SileroEngine::new(config.silero.clone())?)

- **Line:** `Box::new(SileroEngine::new(config.silero.clone())?)`

chatgpt-codex-connector

Codex Review: Here are some suggestions.

ColdVox/crates/app/src/text_injection/manager.rs

Lines 87 to 90 in 6e49b67

    
           // Add clipboard injectors if available 
        
           #[cfg(feature = "text-injection-clipboard")] 
        
           { 
        
               if has_wayland || has_x11 {

[P1] Clipboard injector gate references undeclared variables

The app crate’s injector registry shows the same mismatch: backend flags were renamed _has_wayland and _has_x11, yet the conditional still uses has_wayland/has_x11. Enabling the text-injection-clipboard feature causes an unresolved-name compiler error. Update the condition to use the defined _has_* variables so builds with clipboard support succeed.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

chatgpt-codex-connector · 2025-09-01T19:05:42Z

crates/coldvox-text-injection/src/manager.rs

+        // Add clipboard injectors if available
+        #[cfg(feature = "wl_clipboard")]
+        {
+            if has_wayland || has_x11 {


[P1] Use renamed backend flags to avoid compile error

In InjectorRegistry::build the backend detection variables were renamed to _has_wayland/_has_x11, but the clipboard branch still tests if has_wayland || has_x11. When the wl_clipboard feature is enabled this code does not compile because those identifiers no longer exist. Switch the condition to the _has_* names (or keep the original names) so the clipboard injectors can build successfully.

Useful? React with 👍 / 👎.

Coldaine and others added 4 commits August 31, 2025 06:14

docs: add workspace split plan and text-injection docs (simplificatio…

bd19f52

…n + implementation overview)

docs: remove superseded text-injection plans/runbooks/privacy/securit…

061d6b5

…y to reduce confusion

In progress

fa7a530

Copilot AI review requested due to automatic review settings September 1, 2025 19:01

Copilot AI reviewed Sep 1, 2025

View reviewed changes

chatgpt-codex-connector bot reviewed Sep 1, 2025

View reviewed changes

Coldaine merged commit 5957ad3 into main Sep 1, 2025
0 of 8 checks passed

Coldaine deleted the refactor/workspace-split branch September 1, 2025 23:36

Copilot AI mentioned this pull request Oct 8, 2025

docs: Add comprehensive refactor split strategy comparison and execution-ready plan #122

Merged

This was referenced Oct 8, 2025

[05/09] app: unify VAD↔STT runtime + real WAV loader #127

Merged

[06/09] injection: clipboard-preserve + Wayland-first strategy #128

Merged

[08/09] logs: prune noisy hot paths; telemetry tweaks #130

Merged

		- Line: `use crate::vad::config::{UnifiedVadConfig, VadMode};
		- Fix: `use coldvox_vad::config::{UnifiedVadConfig, VadMode};

		- Line: `use crate::foundation::error::AudioConfig;
		- Fix: `use coldvox_foundation::error::AudioConfig;

	- Line: `use crate::audio::capture::AudioCaptureThread;
	- Line: `use crate::audio::capture::AudioCaptureThread;`

		- Line: `use crate::audio::chunker::{AudioChunker, ChunkerConfig};
		- Fix: `use coldvox_audio::chunker::{AudioChunker, ChunkerConfig};

		- Line: `use crate::audio::frame_reader::FrameReader;
		- Fix: `use coldvox_audio::frame_reader::FrameReader;

	- Line: `use crate::vad::types::VadEvent;
	- Line: `use crate::vad::types::VadEvent;`

	- Line: `use crate::audio::ring_buffer::AudioRingBuffer;
	- Line: `use crate::audio::ring_buffer::AudioRingBuffer;`

	- Line: `resampler_quality: crate::audio::chunker::ResamplerQuality::Balanced,
	- Line: `resampler_quality: crate::audio::chunker::ResamplerQuality::Balanced,`

	- Line: `Box::new(Level3Vad::new(level3_config))
	- Line: `Box::new(Level3Vad::new(level3_config))`

	- Line: `Box::new(SileroEngine::new(config.silero.clone())?)
	- Line: `Box::new(SileroEngine::new(config.silero.clone())?)`

	// Add clipboard injectors if available
	#[cfg(feature = "text-injection-clipboard")]
	{
	if has_wayland \|\| has_x11 {

Conversation

Coldaine commented Sep 1, 2025

Summary

Changes

Architecture Improvements

VAD Integration

Test Fixes

Build Fixes

Test Plan

Impact

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Sep 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant