Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 27, 2026

Updates the requirements on watchdog to permit the latest version.

Release notes

Sourced from watchdog's releases.

6.0.0

Breaking Changes

  • [inotify] Use of select.poll() instead of deprecated select.select(), if available. (#1078)
  • [utils] Removed the unused echo_class() function from the echo module.
  • [utils] Removed the unused echo_instancemethod() function from the echo module.
  • [utils] Removed the unused echo_module() function from the echo module.
  • [utils] Removed the unused is_class_private_name() function from the echo module.
  • [utils] Removed the unused is_classmethod() function from the echo module.
  • [utils] Removed the unused is_method(met() function from the echo module.
  • [utils] Removed the unused method_name() function from the echo module.
  • [utils] Removed the unused name() function from the echo module.
  • [watchmedo] Removed the --trace CLI argument from the watchmedo log command, useless since events are logged by default at the LoggerTrick class level.

Other Changes

  • Pin test dependecies.
  • [docs] Add typing info to quick start. (#1082)
  • [inotify] Fix reading inotify file descriptor after closing it. (#1081)
  • [utils] The stop_signal keyword-argument type of the AutoRestartTrick class can now be either a signal.Signals or an int.
  • [utils] Added the __repr__() method to the Trick class.
  • [watchmedo] Fixed Mypy issues.
  • [watchmedo] Added the __repr__() method to the HelpFormatter class.
  • [windows] Fixed Mypy issues.

💟 Thanks to our beloved contributors: @​g-pichler, @​ethan-vanderheijden, @​nhairs, @​BoboTiG

Changelog

Sourced from watchdog's changelog.

6.0.0


2024-11-01 • `full history <https://github.com/gorakhargosh/watchdog/compare/v5.0.3...v6.0.0>`__
  • Pin test dependencies.
  • [docs] Add typing info to quick start. ([#1082](https://github.com/gorakhargosh/watchdog/issues/1082) &lt;https://github.com/gorakhargosh/watchdog/pull/1082&gt;__)
  • [inotify] Use of select.poll() instead of deprecated select.select(), if available. ([#1078](https://github.com/gorakhargosh/watchdog/issues/1078) &lt;https://github.com/gorakhargosh/watchdog/pull/1078&gt;__)
  • [inotify] Fix reading inotify file descriptor after closing it. ([#1081](https://github.com/gorakhargosh/watchdog/issues/1081) &lt;https://github.com/gorakhargosh/watchdog/pull/1081&gt;__)
  • [utils] The stop_signal keyword-argument type of the AutoRestartTrick class can now be either a signal.Signals or an int.
  • [utils] Added the __repr__() method to the Trick class.
  • [utils] Removed the unused echo_class() function from the echo module.
  • [utils] Removed the unused echo_instancemethod() function from the echo module.
  • [utils] Removed the unused echo_module() function from the echo module.
  • [utils] Removed the unused is_class_private_name() function from the echo module.
  • [utils] Removed the unused is_classmethod() function from the echo module.
  • [utils] Removed the unused ic_method(met() function from the echo module.
  • [utils] Removed the unused method_name() function from the echo module.
  • [utils] Removed the unused name() function from the echo module.
  • [watchmedo] Fixed Mypy issues.
  • [watchmedo] Added the __repr__() method to the HelpFormatter class.
  • [watchmedo] Removed the --trace CLI argument from the watchmedo log command, useless since events are logged by default at the LoggerTrick class level.
  • [windows] Fixed Mypy issues.
  • Thanks to our beloved contributors: @​BoboTiG, @​g-pichler, @​ethan-vanderheijden, @​nhairs

5.0.3

2024-09-27 • full history <https://github.com/gorakhargosh/watchdog/compare/v5.0.2...v5.0.3>__

  • [inotify] Improve cleaning up Inotify threads, and add eventlet test cases ([#1070](https://github.com/gorakhargosh/watchdog/issues/1070) <https://github.com/gorakhargosh/watchdog/pull/1070>__)
  • Thanks to our beloved contributors: @​BoboTiG, @​ethan-vanderheijden

5.0.2


2024-09-03 • `full history <https://github.com/gorakhargosh/watchdog/compare/v5.0.1...v5.0.2>`__
  • Enable OS specific Mypy checks ([#1064](https://github.com/gorakhargosh/watchdog/issues/1064) &lt;https://github.com/gorakhargosh/watchdog/pull/1064&gt;__)
  • [watchmedo] Fix tricks argument type of schedule_tricks() ([#1063](https://github.com/gorakhargosh/watchdog/issues/1063) &lt;https://github.com/gorakhargosh/watchdog/pull/1063&gt;__)
  • Thanks to our beloved contributors: @​gnought, @​BoboTiG

5.0.1

2024-09-02 • full history <https://github.com/gorakhargosh/watchdog/compare/v5.0.0...v5.0.1>__

  • [kqueue] Fix TypeError: kqueue.control() only accepts positional parameters ([#1062](https://github.com/gorakhargosh/watchdog/issues/1062) <https://github.com/gorakhargosh/watchdog/pull/1062>__)
  • Thanks to our beloved contributors: @​apoirier, @​BoboTiG

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [watchdog](https://github.com/gorakhargosh/watchdog) to permit the latest version.
- [Release notes](https://github.com/gorakhargosh/watchdog/releases)
- [Changelog](https://github.com/gorakhargosh/watchdog/blob/master/changelog.rst)
- [Commits](gorakhargosh/watchdog@v4.0.0...v6.0.0)

---
updated-dependencies:
- dependency-name: watchdog
  dependency-version: 6.0.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update python code labels Jan 27, 2026
@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@kiloconnect
Copy link

kiloconnect bot commented Jan 27, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The PR updates watchdog from version ~4.0.0 to ~6.0.0. I reviewed all files that use watchdog:

  1. scripts/comfy_inventory_watcher.py - Uses watchdog's FileSystemEventHandler and Observer
  2. domains/memory_change/watchers/filesystem.py - Uses watchdog's FileSystemEventHandler and Observer
  3. tests/unit/test_comfy_inventory_watcher.py - Tests the watchdog event handler

The breaking changes in watchdog 6.0.0 are:

  • Use of select.poll() instead of select.select() for inotify (which doesn't affect our code)
  • Removal of unused functions from the echo module (we don't use that module)
  • Removal of --trace argument from watchmedo log (we don't use watchmedo)

All usage of watchdog in our codebase is compatible with version 6.0.0.

Files Reviewed
  • pyproject.toml - Updated watchdog version
  • scripts/comfy_inventory_watcher.py - Uses watchdog
  • domains/memory_change/watchers/filesystem.py - Uses watchdog
  • tests/unit/test_comfy_inventory_watcher.py - Tests watchdog usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python Pull requests that update python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants