fix: do not panic on binrw backtrace error #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ntfs crate could panic on some data because of a false "unreachable" instruction in error.rs: the binrw error is not guaranteed to only be an IO error, it can also be for example a backtrace error.
I have reached this panic several times in different contexts.
This PR removes this unreachable which is too dangerous: any update of binrw could make this unreachable wrong, it is better to be conservative here.