Skip to content

Commit

Permalink
slideshow: autostart in window
Browse files Browse the repository at this point in the history
If we use presentation with autostart (.pps) then
fullscreen request fails as it is not invoked by the
user interaction. For now do the fallback -> open in
window. If user has disabled popup, he will be asked
in the message box to allow the popup.

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: I9e8313f697e30fb25fa3d98b3f4a30b7df433a3e
  • Loading branch information
eszkadev authored and mcecchetti committed Sep 30, 2024
1 parent 1daed1b commit 24a1705
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion browser/src/slideshow/SlideShowPresenter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -521,8 +521,8 @@ class SlideShowPresenter {
}

_doFallbackPresentation() {
// TODO: fallback to "open in new tab"
this._stopFullScreen();
this._doInWindowPresentation();
}

_doInWindowPresentation() {
Expand Down Expand Up @@ -736,6 +736,11 @@ class SlideShowPresenter {
const numberOfSlides = this._getSlidesCount();
if (numberOfSlides === 0) return;

if (!this.getCanvas()) {
console.debug('onSlideShowInfo: no canvas available');
return;
}

let skipTransition = false;

if (!this._metaPresentation) {
Expand Down

0 comments on commit 24a1705

Please sign in to comment.