Skip to content

Commit

Permalink
css: fix icons size after split button rework
Browse files Browse the repository at this point in the history
it was broken after PR:
#10027

I'm afraid I was not as clear as I could have been, sorry
#10027 (review)
What I mean is that it's very important to:
* When fixing/improving the style of a given widget to avoid pushing
additional changes that have a high risk of changing many things and
bring regressions
  * I welcome those changes but in an isolated PR which can better
  tested and worked on :)
* Changing sizes of buttons or let them be dynamically set according to
the DOM is a bit hard and prone to problems

Nevertheless this is an attempt to fix those while retain the nice
work from Maks.

Co-authored-by: Szymon Kłos <[email protected]>
Signed-off-by: Pedro Pinto Silva <[email protected]>
Change-Id: I2d6aa5113405aa32e06d45cfbfd1a623647f3121
Signed-off-by: Darshan-upadhyay1110 <[email protected]>
  • Loading branch information
eszkadev authored and Darshan-upadhyay1110 committed Oct 25, 2024
1 parent 2e1ba0d commit 32ed5e8
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
4 changes: 2 additions & 2 deletions browser/css/jsdialogs.css
Original file line number Diff line number Diff line change
Expand Up @@ -1377,8 +1377,8 @@ input[type='number']:hover::-webkit-outer-spin-button {
}

.jsdialog .unobutton img {
min-width: 0;
min-height: 0;
width: var(--btn-img-size);
height: var(--btn-img-size);
}

.menubutton .arrow {
Expand Down
4 changes: 2 additions & 2 deletions browser/css/notebookbar.css
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,8 @@ html[data-theme='dark'] .savemodified.unotoolbutton .unobutton img {
}

.ui-tabs-content .unobutton > img {
min-height: 0;
min-width: 0;
width: var(--btn-size);
height: var(--btn-size);
}

.has-dropdown--color.notebookbar {
Expand Down
5 changes: 4 additions & 1 deletion browser/css/toolbar.css
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,10 @@
background-position: right;
background-repeat: no-repeat;
}

.unospan-optionstoolboxdown .unobutton > img {
width: var(--btn-size);
height: var(--btn-size);
}
#closebuttonwrapper {
order: 99;
flex-shrink: 0;
Expand Down

0 comments on commit 32ed5e8

Please sign in to comment.