Skip to content

Commit

Permalink
fix(android): Use uno command for all clipboard
Browse files Browse the repository at this point in the history
Previously on mobile, we were only using the uno commands for some
clipboard operations - the pasting ones. That's incorrect, as on Android
and iOS we don't have access to the browser clipboard APIs and should be
using the native bits, which for Android intercept these UNO calls and
use them to manage the clipboard.

For iOS, this still falls over - albeit in a slighly different way - but
the iOS clipboard code is in core and is nontrivial to fix. I have a
patch in the works which would make an API similar to
navigator.clipboard for iOS/Android (hopefully reducing our pains here)
but I don't see a point in not making a tiny, temporary Android fix.

When I change the clipboard system's mobile app bits, this will go away
anyway :)

Signed-off-by: Skyler Grey <[email protected]>
Change-Id: Ifa68b6e956cd5ca75dc8f54b4198a441b2bf1887
  • Loading branch information
Minion3665 committed Sep 26, 2024
1 parent f3887f2 commit 3e34215
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion browser/src/map/Clipboard.js
Original file line number Diff line number Diff line change
Expand Up @@ -989,7 +989,7 @@ L.Clipboard = L.Class.extend({
return true;
}

if (window.ThisIsAMobileApp && (cmd === '.uno:Paste' || cmd === '.uno:PasteSpecial')) {
if (window.ThisIsAMobileApp) {
// perform internal operations
app.socket.sendMessage('uno ' + cmd);
return true;
Expand Down

0 comments on commit 3e34215

Please sign in to comment.