Skip to content

Commit

Permalink
Back out "Impress: Fixes invisible typing issue on notes view."
Browse files Browse the repository at this point in the history
This commit, as part of #10186, causes a regression to slide previews on
new slides, which I believe to be more common than editing presenter
text. Therefore, I've decided to back out.

This backs out commit bde181b.

Signed-off-by: Skyler Grey <[email protected]>
Change-Id: If8f53db3b87360681231063d727a373c2267eb61
  • Loading branch information
Minion3665 committed Oct 7, 2024
1 parent 7c29297 commit fb02456
Showing 1 changed file with 0 additions and 16 deletions.
16 changes: 0 additions & 16 deletions wsd/ClientSession.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1215,16 +1215,6 @@ bool ClientSession::_handleInput(const char *buffer, int length)
docBroker->updateLastModifyingActivityTime();
}

/*
When the UI mode is switched, tile invalidation callback is sent before the mode switch callback.
This causes the tiles' ui mode to conflict with the view mode.
We set the view mode beforehand here.
*/
if (firstLine == "uno .uno:NormalMultiPaneGUI")
_clientSelectedMode = 0;
else if (firstLine == "uno .uno:NotesMode")
_clientSelectedMode = 2;

if (!filterMessage(firstLine))
{
const std::string dummyFrame = "dummymsg";
Expand Down Expand Up @@ -2333,12 +2323,6 @@ bool ClientSession::handleKitToClientMessage(const std::shared_ptr<Message>& pay
// Forward the status response to the client.
return forwardToClient(payload);
}
else if (tokens.equals(0, "statusupdate:"))
{
uint32_t newValue;
if (tokens.getUInt32(7, "mode", newValue))
this->_clientSelectedMode = newValue;
}
else if (tokens.equals(0, "commandvalues:"))
{
const std::string stringJSON = payload->jsonString();
Expand Down

0 comments on commit fb02456

Please sign in to comment.