-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve split button styling #8566
Comments
I would like to work on this issue. Don't know much web-programming, but I hope I can come up with something working coming saturday-sunday. |
Hii @eszkadev after merging solution for this issue can you please add "Hacktoberfest-accepted" label here? |
@Darshan-upadhyay1110 hello i want to contribute to this repo how can I do that |
Hi @Saurabhyadav0! Welcome! There are plenty of interesting issues waiting to be solved. You can find them here: Open Issues. Feel free to pick any issue, and don't hesitate to reach out if you need any help. Also, it's Hacktoberfest season! If you're interested, you can register and join in here: Hacktoberfest. Check out more details on how to participate: Collabora Online Hacktoberfest. |
@Darshan-upadhyay1110 thank you ! but i want to know that how I can know that if I am solving a issue that is in hacktober fest or not . Is this whole repo is in hacktoberfest !all the issues |
@Saurabhyadav0 Issues with tag "Hacktoberfest" are only ones :) Hacktoberfest |
This is an Easy Hack.
Potential mentors: @pedropintosilva @eszkadev
Detailed description and rationale
Split buttons are buttons which have 2 parts: "
<direct command button>
|<dropdown arrow>
"Left one applies/runs some command but right part opens dropdown with more options.
It should be marked in the UI as 2 separate parts somehow. This is used for color pickers in notebookbar for example.
Notice that there are MenuButtons which doesn't have different actions for arrow and icon - Paste button in notebookbar.
See how it looks now:
split-button-2024-03-18_18.22.50.webm
Currently on hover we highlight full button. It is not possible to differentiate between split and regular menu button.
Code pointers
Split button is a kind of MenuButton: https://github.com/CollaboraOnline/online/blob/master/browser/src/control/jsdialog/Widget.MenuButton.js#L118
The text was updated successfully, but these errors were encountered: