feat(UI): Improve split button styling #10027
Open
+78
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eszkadev
reviewed
Sep 11, 2024
maks-w
force-pushed
the
maks-w/improve-split-button-styling
branch
12 times, most recently
from
cea76c8
to
bfb47c3
Compare
Signed-off-by: Maks Wolkowinski <[email protected]> Change-Id: I4f0474e02411ada5547c8c2f23dda22cb4433557
maks-w
force-pushed
the
maks-w/improve-split-button-styling
branch
from
bfb47c3
to
11a8e52
Compare
maks-w
commented
Sep 12, 2024
| .jsdialog.unotoolbutton.selected:hover { | ||
| background-color: var(--color-background-darker) !important; |
There was a problem hiding this comment.
We move the responsability of the background-color to the children since a button could have 2 parts
maks-w
commented
Sep 12, 2024
| } | ||
|
|
||
| .unoarrow::after, | ||
| .jsdialog .ui-content.unobutton::after { |
There was a problem hiding this comment.
I extended a little bit the click zone so that the border of the button could be clickable
maks-w
commented
Sep 12, 2024
| @@ -37,6 +37,7 @@ describe(['tagdesktop', 'tagnextcloud', 'tagproxy'], 'Delete Objects', function( | |||
| }); | |||
|
|
|||
| it('Delete Chart' , function() { | |||
| cy.cGet('#toolbar-up > .ui-scroll-right').click(); | |||
| cy.cGet('#toolbar-up > .ui-scroll-right').click(); | |||
There was a problem hiding this comment.
The menu is a bit wider now, so we need to click twice for the icon to appear.
|
I see no problem with the JS code thanks! @pedropintosilva will you find a minute to review the new look of split button? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I4f0474e02411ada5547c8c2f23dda22cb4433557
Summary
This is my proposal for UI splitting the buttons in 2 parts.
I hope I didn't take too much liberty with the design ^^
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay