Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calc: Function Wizard: broken UI #9770

Open
bayramcicek opened this issue Aug 9, 2024 · 1 comment · May be fixed by #9869
Open

Calc: Function Wizard: broken UI #9770

bayramcicek opened this issue Aug 9, 2024 · 1 comment · May be fixed by #9869
Labels
24.04 bug Something isn't working regression Something that was working in the past, but not now

Comments

@bayramcicek
Copy link
Member

bayramcicek commented Aug 9, 2024 •
edited
Loading

Describe the Bug

  • Function Wizard: some button(s), labels and checkbox(es) are mis-aligned and scroll bar behaves strange:
Peek.2024-08-09.21-27.mp4
  • formula wizard doesn't show the input fields (Szymon)

formulawizard

version

COOLWSD version: 24.04.6.1 (git hash: ed4edcc)
LOKit version: Collabora Office 24.04.6.1 (git hash: 5797d70)
Served by: Manjaro Linux
Server ID: e9966fd2
@bayramcicek bayramcicek added bug Something isn't working unconfirmed labels Aug 9, 2024
@eszkadev
Copy link
Contributor

This might be related to the: #9559
Which is regression from 5b03c12

meven added a commit to meven/cool-online that referenced this issue Aug 19, 2024
@meven
scrollWindow: fix view scrolling
4046231 
 * make scrollWindow height fix
 * special case data.horizontal.page_size == 0
 * improve computation of rowHeight
 * don't resize dynamically dimensions based on dom changes

Fixes CollaboraOnline#9770

Signed-off-by: Méven Car <[email protected]>
Change-Id: I54990645d17e1e352397f1d57b4cc671af6b5839
meven added a commit to meven/cool-online that referenced this issue Aug 19, 2024
@meven
scrollWindow: fix view scrolling
68b4fc0 
 * make scrollWindow height fix
 * special case data.horizontal.page_size == 0
 * improve computation of rowHeight
 * don't resize dynamically dimensions based on dom changes

Fixes CollaboraOnline#9770

Signed-off-by: Méven Car <[email protected]>
Change-Id: I54990645d17e1e352397f1d57b4cc671af6b5839
meven added a commit to meven/cool-online that referenced this issue Aug 19, 2024
@meven
scrollWindow: fix view scrolling
d3fd7d5 
 * make scrollWindow height fix
 * special case data.horizontal.page_size == 0
 * improve computation of rowHeight
 * don't resize dynamically dimensions based on dom changes

Fixes CollaboraOnline#9770

Signed-off-by: Méven Car <[email protected]>
Change-Id: I54990645d17e1e352397f1d57b4cc671af6b5839
meven added a commit to meven/cool-online that referenced this issue Aug 19, 2024
@meven
scrollWindow: fix view scrolling
ca8a18a 
 * make scrollWindow height fix
 * special case data.horizontal.page_size == 0
 * improve computation of rowHeight
 * don't resize dynamically dimensions based on dom changes

Fixes CollaboraOnline#9770

Signed-off-by: Méven Car <[email protected]>
Change-Id: I54990645d17e1e352397f1d57b4cc671af6b5839
meven added a commit to meven/cool-online that referenced this issue Aug 21, 2024
@meven
scrollWindow: fix view scrolling
a1daa0f 
 * make scrollWindow height fix
 * special case data.horizontal.page_size == 0
 * improve computation of rowHeight
 * don't resize dynamically dimensions based on dom changes

Fixes CollaboraOnline#9770

Signed-off-by: Méven Car <[email protected]>
Change-Id: I54990645d17e1e352397f1d57b4cc671af6b5839
@meven meven linked a pull request Aug 21, 2024 that will close this issue
Open
5 tasks
meven added a commit to meven/cool-online that referenced this issue Aug 21, 2024
@meven
scrollWindow: fix view scrolling
2f28839 
 * make scrollWindow height fix
 * special case data.horizontal.page_size == 0
 * improve computation of rowHeight
 * don't resize dynamically dimensions based on dom changes

Fixes CollaboraOnline#9770

Signed-off-by: Méven Car <[email protected]>
Change-Id: I54990645d17e1e352397f1d57b4cc671af6b5839
@eszkadev eszkadev mentioned this issue Aug 27, 2024
Merged
@thebearon thebearon added regression Something that was working in the past, but not now 24.04 labels Aug 27, 2024
eszkadev added a commit that referenced this issue Aug 29, 2024
@eszkadev
Revert "scrollWindow: Corrected the property name from 'scrollwidth' …
d9706a8 
…to 'scrollWidth' in the _scrolledWindowControl function"

This reverts commit 15ffda9.
Related to issues #9614 #9559 #9770

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: I19d44db2252de91c0ca637256239d4a9405e1c31
eszkadev added a commit that referenced this issue Aug 29, 2024
@eszkadev
Revert "jsdialog: send less messages for scrolled window"
806a8f2 
This reverts commit fd35bd7.
Related to issues #9614 #9559 #9770

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: If703d2c20ceee4321520aa01a5b55c95e3c27113
eszkadev added a commit that referenced this issue Aug 29, 2024
@eszkadev
Revert "Widget.ScrolledWindow: allow to resize based on content"
3f2c383 
This reverts commit c5cd333.
Related to issues #9614 #9559 #9770

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: I24967889c7b9a75d1afcdbdb67e04f45eaf230b6
@eszkadev eszkadev mentioned this issue Aug 29, 2024
Merged
timar pushed a commit that referenced this issue Aug 29, 2024
@eszkadev @timar
Revert "scrollWindow: Corrected the property name from 'scrollwidth' …
2b00482 
…to 'scrollWidth' in the _scrolledWindowControl function"

This reverts commit 15ffda9.
Related to issues #9614 #9559 #9770

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: I19d44db2252de91c0ca637256239d4a9405e1c31
timar pushed a commit that referenced this issue Aug 29, 2024
@eszkadev @timar
Revert "jsdialog: send less messages for scrolled window"
0bcebdf 
This reverts commit fd35bd7.
Related to issues #9614 #9559 #9770

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: If703d2c20ceee4321520aa01a5b55c95e3c27113
timar pushed a commit that referenced this issue Aug 29, 2024
@eszkadev @timar
Revert "Widget.ScrolledWindow: allow to resize based on content"
28cf77a 
This reverts commit c5cd333.
Related to issues #9614 #9559 #9770

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: I24967889c7b9a75d1afcdbdb67e04f45eaf230b6
meven added a commit to meven/cool-online that referenced this issue Aug 29, 2024
@meven
scrollWindow: fix view scrolling
08e8a9c 
 * make scrollWindow height fix
 * special case data.horizontal.page_size == 0
 * improve computation of rowHeight
 * don't resize dynamically dimensions based on dom changes

Fixes CollaboraOnline#9770

Signed-off-by: Méven Car <[email protected]>
Change-Id: I54990645d17e1e352397f1d57b4cc671af6b5839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
24.04 bug Something isn't working regression Something that was working in the past, but not now
Projects
Collabora Online
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

scrollWindow: fix view scrolling meven/cool-online
3 participants
@eszkadev @thebearon @bayramcicek