scrollWindow: fix view scrolling

[meven]

Change-Id: I54990645d17e1e352397f1d57b4cc671af6b5839

• Resolves: Calc: Function Wizard: broken UI #9770
• Target version: master

Summary

• make scrollWindow height fix
• special case data.horizontal.page_size == 0
• improve computation of rowHeight
• don't resize dynamically dimensions based on dom changes

Checklist

• I have run make prettier-write and formatted the code.
• All commits have Change-Id
• I have run tests with make check
• I have issued make run and manually verified that everything looks okay
• Documentation (manuals or wiki) has been updated or is not required

[eszkadev]

It works nice in most of the cases, but still has problems with vertical scrolling in "managed by user" mode.

symbols-2024-08-22_10.36.24.webm

It worked in the past before regression commit, it was also not doing "scrolling animation" so UI looked less buggy/jumping.

[eszkadev]

please try to fix vertical scrolling

[meven]

The use cases to test:

In calc:

• function wizard, select AGGREGATE and try to scroll
• insert symbol
• properties > custom properties tab.

[eszkadev]

This works bad:
scroll-2024-08-30_08.54.08.webm

I used keyboard (arrow down) in symbol dialog.

Please see how it works with the reverted version (current master):
scroll-2024-08-30_08.57.03.webm

Can we just setup the size of scroll window in the file properties dialog for custom properties using CSS?
I think behavior now is ok, only look of custom properties tab is not good.

[meven]

Can we just setup the size of scroll window in the file properties dialog for custom properties using CSS?

The content size is dynamic in the custom properties and function wizard, there it is not possible and in the symbol dialog it would break when we add new symbols.

[meven]

This works bad: scroll-2024-08-30_08.54.08.webm

I used keyboard (arrow down) in symbol dialog.

I noticed it, I have an idea how to fix that.

[eszkadev]

Can we just setup the size of scroll window in the file properties dialog for custom properties using CSS?

The content size is dynamic in the custom properties and function wizard, there it is not possible and in the symbol dialog it would break when we add new symbols.

@meven with current master (with revert) it works well in all of these dialogs apart custom properties.

Really isn't it enough to fix custom properties sizing on top of current master ?
Like some CSS: to make scroll-window height depending on height of the dialog and rest of the items static.

[meven]

Really isn't it enough to fix custom properties sizing on top of current master ?
Like some CSS: to make scroll-window height depending on height of the dialog and rest of the items static.

My patches sets the scroll-window "view" height, in browser/css/jsdialogs.css.
But that's the content-height that's dynamic.